Merge pull request #3540 from miloush/AlwaysMoveInitializer

Always move initializer decompilation setting

Author: siegfriedpammer

ICSharpCode.Decompiler/CSharp/Transforms/TransformFieldAndConstructorInitializers.cs

@@ -350,7 +350,7 @@ void HandleStaticFieldInitializers(IEnumerable<AstNode> members)
 						if (!(fieldOrProperty is IField || fieldOrProperty is IProperty) || !fieldOrProperty.IsStatic)
 							break;
 						// Only move fields that are constants, if the declaring type is not marked beforefieldinit.
-						if (!declaringTypeIsBeforeFieldInit && fieldOrProperty is not IField { IsConst: true })
+						if (!context.Settings.AlwaysMoveInitializer && !declaringTypeIsBeforeFieldInit && fieldOrProperty is not IField { IsConst: true })
 						{
 							pos++;
 							continue;

ICSharpCode.Decompiler/DecompilerSettings.cs

@@ -2274,6 +2274,27 @@ public bool AlwaysUseGlobal {
 			}
 		}
 
+		bool alwaysMoveInitializer = false;
+
+		/// <summary>
+		/// If set to false (the default), the decompiler will move field initializers at the start of constructors
+		/// to their respective field declrations (TransformFieldAndConstructorInitializers) only when the declaring
+		/// type has BeforeFieldInit or the member IsConst.
+		/// If set true, the decompiler will always move them regardless of the flags.
+		/// </summary>
+		[Category("DecompilerSettings.Other")]
+		[Description("DecompilerSettings.AlwaysMoveInitializer")]
+		public bool AlwaysMoveInitializer {
+			get { return alwaysMoveInitializer; }
+			set {
+				if (alwaysMoveInitializer != value)
+				{
+					alwaysMoveInitializer = value;
+					OnPropertyChanged();
+				}
+			}
+		}
+
 		bool sortCustomAttributes = false;
 
 		/// <summary>

ILSpy/Properties/Resources.Designer.cs

@@ -264,6 +264,9 @@ Are you sure you want to continue?</value>
   <data name="DecompilerSettings.AlwaysCastTargetsOfExplicitInterfaceImplementationCalls" xml:space="preserve">
     <value>Always cast targets of explicit interface implementation calls</value>
   </data>
+  <data name="DecompilerSettings.AlwaysMoveInitializer" xml:space="preserve">
+    <value>Always move field initializers from constructors to declarations</value>
+  </data>
   <data name="DecompilerSettings.AlwaysQualifyMemberReferences" xml:space="preserve">
     <value>Always qualify member references</value>
   </data>
@@ -361,7 +364,7 @@ Are you sure you want to continue?</value>
     <value>Transform to do-while, if possible</value>
   </data>
   <data name="DecompilerSettings.ExpandParamsArguments" xml:space="preserve">
-	  <value>Expand params arguments by removing explicit array creation</value>
+    <value>Expand params arguments by removing explicit array creation</value>
   </data>
   <data name="DecompilerSettings.FSpecificOptions" xml:space="preserve">
     <value>F#-specific options</value>

ILSpy/Properties/Resources.resx

@@ -258,6 +258,9 @@
   <data name="DecompilerSettings.AlwaysCastTargetsOfExplicitInterfaceImplementationCalls" xml:space="preserve">
     <value>始终强制转换显式接口实现调用的目标</value>
   </data>
+  <data name="DecompilerSettings.AlwaysMoveInitializer" xml:space="preserve">
+    <value />
+  </data>
   <data name="DecompilerSettings.AlwaysQualifyMemberReferences" xml:space="preserve">
     <value>始终限定成员引用</value>
   </data>