From 22be63a5c2ba52e33207913ca27d6cd384048ee5 Mon Sep 17 00:00:00 2001 From: Guillaume Giudicelli Date: Fri, 13 Dec 2024 12:28:20 -0700 Subject: [PATCH 1/2] Remove a few linear executions which may not be needed refs #66 --- microreactors/mrad/heat_pipe_failure/HPMR_sockeye_tr.i | 2 +- microreactors/mrad/heat_pipe_failure/HPMR_thermo_tr.i | 3 ++- microreactors/mrad/load_following/HPMR_sockeye_tr.i | 2 +- microreactors/mrad/steady/HPMR_sockeye_ss.i | 2 +- microreactors/mrad/steady/HPMR_thermo_ss.i | 3 ++- microreactors/mrad/transient_null/HPMR_sockeye_trN.i | 2 +- 6 files changed, 8 insertions(+), 6 deletions(-) diff --git a/microreactors/mrad/heat_pipe_failure/HPMR_sockeye_tr.i b/microreactors/mrad/heat_pipe_failure/HPMR_sockeye_tr.i index 25ff3c673..b64eeadea 100644 --- a/microreactors/mrad/heat_pipe_failure/HPMR_sockeye_tr.i +++ b/microreactors/mrad/heat_pipe_failure/HPMR_sockeye_tr.i @@ -384,7 +384,7 @@ T_ext_cond = 800. type = SideIntegralVariablePostprocessor variable = virtual_Text boundary = 'hp:evap:inner' - execute_on = 'INITIAL LINEAR' + execute_on = 'INITIAL TIMESTEP_END' [] [A_avg_T_aux] type = AverageNodalVariableValue diff --git a/microreactors/mrad/heat_pipe_failure/HPMR_thermo_tr.i b/microreactors/mrad/heat_pipe_failure/HPMR_thermo_tr.i index a9fcc0f04..49c319cb3 100644 --- a/microreactors/mrad/heat_pipe_failure/HPMR_thermo_tr.i +++ b/microreactors/mrad/heat_pipe_failure/HPMR_thermo_tr.i @@ -299,7 +299,8 @@ corr_factor = '${fparse R_hp_hole / R_clad_o * area_correction / perimeter_corre points_file = 'hp_centers.txt' variable = temp diffusivity = thermal_conductivity - execute_on = linear + # Must be executed before the transfer + execute_on = 'INITIAL TIMESTEP_END' boundary = 'heat_pipe_ht_surf' [] [] diff --git a/microreactors/mrad/load_following/HPMR_sockeye_tr.i b/microreactors/mrad/load_following/HPMR_sockeye_tr.i index c1d732e31..64320ff1c 100644 --- a/microreactors/mrad/load_following/HPMR_sockeye_tr.i +++ b/microreactors/mrad/load_following/HPMR_sockeye_tr.i @@ -375,7 +375,7 @@ htc_ext_cond = 1.0e2 type = SideIntegralVariablePostprocessor variable = virtual_Text boundary = 'hp:evap:inner' - execute_on = 'INITIAL LINEAR' + execute_on = 'INITIAL TIMESTEP_END' [] [A_avg_T_aux] type = AverageNodalVariableValue diff --git a/microreactors/mrad/steady/HPMR_sockeye_ss.i b/microreactors/mrad/steady/HPMR_sockeye_ss.i index 2f5c89219..6e2504051 100644 --- a/microreactors/mrad/steady/HPMR_sockeye_ss.i +++ b/microreactors/mrad/steady/HPMR_sockeye_ss.i @@ -372,7 +372,7 @@ q_evap = '${fparse Q_hp / S_evap}' type = SideIntegralVariablePostprocessor variable = virtual_Text boundary = 'hp:evap:inner' - execute_on = 'INITIAL LINEAR' + execute_on = 'INITIAL TIMESTEP_END' [] [A_avg_T_aux] type = AverageNodalVariableValue diff --git a/microreactors/mrad/steady/HPMR_thermo_ss.i b/microreactors/mrad/steady/HPMR_thermo_ss.i index 50a640303..09c47032d 100644 --- a/microreactors/mrad/steady/HPMR_thermo_ss.i +++ b/microreactors/mrad/steady/HPMR_thermo_ss.i @@ -290,7 +290,8 @@ corr_factor = '${fparse R_hp_hole / R_clad_o * area_correction / perimeter_corre points_file = 'hp_centers.txt' variable = temp diffusivity = thermal_conductivity - execute_on = linear + # must be executed before the transfer + execute_on = 'INITIAL TIMESTEP_END' boundary = 'heat_pipe_ht_surf' [] [] diff --git a/microreactors/mrad/transient_null/HPMR_sockeye_trN.i b/microreactors/mrad/transient_null/HPMR_sockeye_trN.i index b1fa53715..2f4849679 100644 --- a/microreactors/mrad/transient_null/HPMR_sockeye_trN.i +++ b/microreactors/mrad/transient_null/HPMR_sockeye_trN.i @@ -375,7 +375,7 @@ htc_ext_cond = 1.0e6 type = SideIntegralVariablePostprocessor variable = virtual_Text boundary = 'hp:evap:inner' - execute_on = 'INITIAL LINEAR' + execute_on = 'INITIAL TIMESTEP_END' [] [A_avg_T_aux] type = AverageNodalVariableValue From 9ae897442011e35496e618dd8762b92bba5e4a3c Mon Sep 17 00:00:00 2001 From: Guillaume Giudicelli Date: Mon, 31 Mar 2025 07:32:04 -0600 Subject: [PATCH 2/2] Remove 'INITIAL' to avoid diffing, and use TRANSFER which should be equivalent to previous schedule --- microreactors/mrad/heat_pipe_failure/HPMR_thermo_tr.i | 2 +- microreactors/mrad/load_following/HPMR_sockeye_tr.i | 2 +- microreactors/mrad/load_following/HPMR_thermo_tr.i | 3 ++- microreactors/mrad/steady/HPMR_thermo_ss.i | 2 +- microreactors/mrad/transient_null/HPMR_thermo_trN.i | 3 ++- 5 files changed, 7 insertions(+), 5 deletions(-) diff --git a/microreactors/mrad/heat_pipe_failure/HPMR_thermo_tr.i b/microreactors/mrad/heat_pipe_failure/HPMR_thermo_tr.i index 49c319cb3..9f25d5d9b 100644 --- a/microreactors/mrad/heat_pipe_failure/HPMR_thermo_tr.i +++ b/microreactors/mrad/heat_pipe_failure/HPMR_thermo_tr.i @@ -300,7 +300,7 @@ corr_factor = '${fparse R_hp_hole / R_clad_o * area_correction / perimeter_corre variable = temp diffusivity = thermal_conductivity # Must be executed before the transfer - execute_on = 'INITIAL TIMESTEP_END' + execute_on = 'TRANSFER' boundary = 'heat_pipe_ht_surf' [] [] diff --git a/microreactors/mrad/load_following/HPMR_sockeye_tr.i b/microreactors/mrad/load_following/HPMR_sockeye_tr.i index 64320ff1c..44d0edd78 100644 --- a/microreactors/mrad/load_following/HPMR_sockeye_tr.i +++ b/microreactors/mrad/load_following/HPMR_sockeye_tr.i @@ -299,7 +299,7 @@ htc_ext_cond = 1.0e2 catastrophic_heat_removal_limit_pps = '' recoverable_heat_removal_limit_pps = 'hp_sonic_limit hp_viscous_limit' T = T_inner_avg - execute_on = 'INITIAL linear nonlinear TIMESTEP_END' + execute_on = 'INITIAL TIMESTEP_END' [] [T_evap_inner] type = SideAverageValue diff --git a/microreactors/mrad/load_following/HPMR_thermo_tr.i b/microreactors/mrad/load_following/HPMR_thermo_tr.i index a79385458..300511d03 100644 --- a/microreactors/mrad/load_following/HPMR_thermo_tr.i +++ b/microreactors/mrad/load_following/HPMR_thermo_tr.i @@ -290,7 +290,8 @@ corr_factor = '${fparse R_hp_hole / R_clad_o * area_correction / perimeter_corre points_file = 'hp_centers.txt' variable = temp diffusivity = thermal_conductivity - execute_on = linear + # Must be executed before the transfer + execute_on = 'TRANSFER' boundary = 'heat_pipe_ht_surf' [] [] diff --git a/microreactors/mrad/steady/HPMR_thermo_ss.i b/microreactors/mrad/steady/HPMR_thermo_ss.i index 09c47032d..ee8f6009b 100644 --- a/microreactors/mrad/steady/HPMR_thermo_ss.i +++ b/microreactors/mrad/steady/HPMR_thermo_ss.i @@ -291,7 +291,7 @@ corr_factor = '${fparse R_hp_hole / R_clad_o * area_correction / perimeter_corre variable = temp diffusivity = thermal_conductivity # must be executed before the transfer - execute_on = 'INITIAL TIMESTEP_END' + execute_on = 'TRANSFER' boundary = 'heat_pipe_ht_surf' [] [] diff --git a/microreactors/mrad/transient_null/HPMR_thermo_trN.i b/microreactors/mrad/transient_null/HPMR_thermo_trN.i index 37bea9f1c..0ba6b3d75 100644 --- a/microreactors/mrad/transient_null/HPMR_thermo_trN.i +++ b/microreactors/mrad/transient_null/HPMR_thermo_trN.i @@ -290,7 +290,8 @@ corr_factor = '${fparse R_hp_hole / R_clad_o * area_correction / perimeter_corre points_file = 'hp_centers.txt' variable = temp diffusivity = thermal_conductivity - execute_on = linear + # must be executed before the transfer + execute_on = 'TRANSFER' boundary = 'heat_pipe_ht_surf' [] []