Improve code quality

Author: ckittl

src/main/java/edu/ie3/tools/models/persistence/ICONWeatherModel.java

@@ -172,47 +172,49 @@ public static String getSQLUpsertStatement(Collection<ICONWeatherModel> entities
   public static String getSQLUpsertStatement(
       Collection<ICONWeatherModel> entities, String database_schema) {
     StringBuilder upsertStatementBuilder = new StringBuilder();
-    upsertStatementBuilder.append(
-        "INSERT INTO "
-            + database_schema
-            + ".weather(\n"
-            + "\ttime, alb_rad, asob_s, aswdifd_s, aswdifu_s, aswdir_s, sobs_rad, p_20m, p_65m, p_131m, t_131m, t_2m, t_g, u_10m, u_131m, u_20m, u_216m, u_65m, v_10m, v_131m, v_20m, v_216m, v_65m, w_131m, w_20m, w_216m, w_65m, z0, coordinate_id)\n"
-            + "\t VALUES ");
+    upsertStatementBuilder
+        .append("INSERT INTO ")
+        .append(database_schema)
+        .append(".weather(\n")
+        .append(
+            "\ttime, alb_rad, asob_s, aswdifd_s, aswdifu_s, aswdir_s, sobs_rad, p_20m, p_65m, p_131m, t_131m, t_2m, t_g, u_10m, u_131m, u_20m, u_216m, u_65m, v_10m, v_131m, v_20m, v_216m, v_65m, w_131m, w_20m, w_216m, w_65m, z0, coordinate_id)\n")
+        .append("\t VALUES ");
     entities.forEach(
-        entity -> upsertStatementBuilder.append(entity.getSQLInsertValuesString() + ", "));
+        entity -> upsertStatementBuilder.append(entity.getSQLInsertValuesString()).append(", "));
     int lastComma = upsertStatementBuilder.lastIndexOf(",");
     upsertStatementBuilder.deleteCharAt(lastComma);
-    upsertStatementBuilder.append("ON CONFLICT (coordinate_id, time) DO UPDATE \n" + "  SET ");
-    upsertStatementBuilder.append(
-        "time=excluded.time,\n"
-            + " alb_rad=excluded.alb_rad,\n"
-            + " asob_s=excluded.asob_s,\n"
-            + " aswdifd_s=excluded.aswdifd_s,\n"
-            + " aswdifu_s=excluded.aswdifu_s,\n"
-            + " aswdir_s=excluded.aswdir_s,\n"
-            + " sobs_rad=excluded.sobs_rad,\n"
-            + " p_20m=excluded.p_20m,\n"
-            + " p_65m=excluded.p_65m,\n"
-            + " p_131m=excluded.p_131m,\n"
-            + " t_131m=excluded.t_131m,\n"
-            + " t_2m=excluded.t_2m,\n"
-            + " t_g=excluded.t_g,\n"
-            + " u_10m=excluded.u_10m,\n"
-            + " u_131m=excluded.u_131m,\n"
-            + " u_20m=excluded.u_20m,\n"
-            + " u_216m=excluded.u_216m,\n"
-            + " u_65m=excluded.u_65m,\n"
-            + " v_10m=excluded.v_10m,\n"
-            + " v_131m=excluded.v_131m,\n"
-            + " v_20m=excluded.v_20m,\n"
-            + " v_216m=excluded.v_216m,\n"
-            + " v_65m=excluded.v_65m,\n"
-            + " w_131m=excluded.w_131m,\n"
-            + " w_20m=excluded.w_20m,\n"
-            + " w_216m=excluded.w_216m,\n"
-            + " w_65m=excluded.w_65m,\n"
-            + " z0=excluded.z0,\n"
-            + " coordinate_id=excluded.coordinate_id;");
+    upsertStatementBuilder
+        .append("ON CONFLICT (coordinate_id, time) DO UPDATE \n" + "  SET ")
+        .append(
+            "time=excluded.time,\n"
+                + " alb_rad=excluded.alb_rad,\n"
+                + " asob_s=excluded.asob_s,\n"
+                + " aswdifd_s=excluded.aswdifd_s,\n"
+                + " aswdifu_s=excluded.aswdifu_s,\n"
+                + " aswdir_s=excluded.aswdir_s,\n"
+                + " sobs_rad=excluded.sobs_rad,\n"
+                + " p_20m=excluded.p_20m,\n"
+                + " p_65m=excluded.p_65m,\n"
+                + " p_131m=excluded.p_131m,\n"
+                + " t_131m=excluded.t_131m,\n"
+                + " t_2m=excluded.t_2m,\n"
+                + " t_g=excluded.t_g,\n"
+                + " u_10m=excluded.u_10m,\n"
+                + " u_131m=excluded.u_131m,\n"
+                + " u_20m=excluded.u_20m,\n"
+                + " u_216m=excluded.u_216m,\n"
+                + " u_65m=excluded.u_65m,\n"
+                + " v_10m=excluded.v_10m,\n"
+                + " v_131m=excluded.v_131m,\n"
+                + " v_20m=excluded.v_20m,\n"
+                + " v_216m=excluded.v_216m,\n"
+                + " v_65m=excluded.v_65m,\n"
+                + " w_131m=excluded.w_131m,\n"
+                + " w_20m=excluded.w_20m,\n"
+                + " w_216m=excluded.w_216m,\n"
+                + " w_65m=excluded.w_65m,\n"
+                + " z0=excluded.z0,\n"
+                + " coordinate_id=excluded.coordinate_id;");
     return upsertStatementBuilder.toString();
   }