Skip to content

Commit c932a4e

Browse files
Updated as per the review comments
Signed-off-by: Abhijit Nathwani <[email protected]>
1 parent 5a9dc44 commit c932a4e

File tree

2 files changed

+4
-4
lines changed

2 files changed

+4
-4
lines changed

README.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -339,13 +339,13 @@ Customize the output image/video directory location:
339339
$ git-sim --media-dir=path/to/output status
340340
```
341341

342-
Optionally, set the environment variable `git_sim_media_dir` to default that as the media directory, if no `--media-dir` is provided.
342+
Optionally, set the environment variable `git_sim_media_dir` to set a global default media directory, to be used if no `--media-dir` is provided. Simulated output images/videos will be placed in this location, in subfolders named with the corresponding repo's name.
343343

344344
```console
345345
$ export git_sim_media_dir=path/to/media/directory
346346
$ git-sim status
347347
```
348-
Note: `--media-dir` takes precedence over the environment variable. If you set the environment and still provide the argument, you'll find the media in the path provided by `--media-dir`
348+
Note: `--media-dir` takes precedence over the environment variable. If you set the environment and still provide the argument, you'll find the media in the path provided by `--media-dir`.
349349

350350
Generate output video in low quality to speed up rendering time (useful for repeated testing, must include `--animate`):
351351

git_sim/__main__.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -85,8 +85,8 @@ def main():
8585
config.media_dir = os.path.join(os.path.expanduser(args.media_dir), "git-sim_media")
8686
config.verbosity = "ERROR"
8787

88-
# If the env variable is set and no argument provideed, use the env variable value
89-
if os.getenv('git_sim_media_dir') is not None and args.media_dir == '.':
88+
# If the env variable is set and no argument provided, use the env variable value
89+
if os.getenv('git_sim_media_dir') and args.media_dir == '.':
9090
config.media_dir = os.path.join(os.path.expanduser(os.getenv('git_sim_media_dir')), "git-sim_media", repo_name)
9191

9292
if ( args.low_quality ):

0 commit comments

Comments
 (0)