[MBL-19448][S] To-do - Improvements (#3781)

refs: MBL-19448
builds: Student
affects: Student
release note: none

Author: vargaat

Core/Core/Common/CommonModels/Store/UseCase.swift

@@ -170,25 +170,26 @@ public extension UseCase {
                 performUIUpdate {
                     completion(.failure(error))
                 }
-            } else {
-                environment.database.performWriteTask { context in
-                    do {
-                        self.reset(context: context)
-                        self.write(response: response, urlResponse: urlResponse, to: context)
-                        self.updateTTL(in: context)
-                        try context.save()
-                        performUIUpdate {
-                            completion(.success((response, urlResponse)))
-                        }
-                    } catch let dbError {
-                        Logger.shared.error(dbError.localizedDescription)
-                        RemoteLogger.shared.logError(
-                            name: "CoreData save failed",
-                            reason: dbError.localizedDescription
-                        )
-                        performUIUpdate {
-                            completion(.failure(dbError))
-                        }
+                return
+            }
+
+            environment.database.performWriteTask { context in
+                do {
+                    self.reset(context: context)
+                    self.write(response: response, urlResponse: urlResponse, to: context)
+                    self.updateTTL(in: context)
+                    try context.save()
+                    performUIUpdate {
+                        completion(.success((response, urlResponse)))
+                    }
+                } catch let dbError {
+                    Logger.shared.error(dbError.localizedDescription)
+                    RemoteLogger.shared.logError(
+                        name: "CoreData save failed",
+                        reason: dbError.localizedDescription
+                    )
+                    performUIUpdate {
+                        completion(.failure(dbError))
                     }
                 }
             }

Core/Core/Common/CommonUI/InstUI/Utils/SwipeAction.swift

@@ -38,10 +38,14 @@ extension View {
     /// - Parameters:
     ///   - backgroundColor: The background color revealed behind the content during the swipe.
     ///   - completionBehavior: Determines what happens after the swipe action completes. Defaults to `.stayOpen`.
-    ///   - isSwiping: Binding that tracks whether a swipe gesture is currently active. Use this to disable scrolling or other gestures while swiping.
+    ///   - isSwiping: Binding that tracks whether a swipe gesture is currently active.
+    ///                Use this to disable scrolling or other gestures while swiping.
     ///   - isEnabled: Whether the swipe gesture is enabled. Defaults to `true`.
-    ///   - onSwipeCommitted: Optional closure called immediately when the swipe action is committed (user releases after reaching threshold) but before animations finish.
-    ///   - onSwipe: Closure called when the swipe action is completed animations included. For `.reset` behavior, this is called after the close animation finishes. For `.stayOpen` behavior, this is called while the open animation is running.
+    ///   - onSwipeCommitted: Optional closure called immediately when the swipe action is committed
+    ///                       (user releases after reaching threshold) but before animations finish.
+    ///   - onSwipe: Closure called when the swipe action is completed animations included.
+    ///              For `.reset` behavior, this is called after the close animation finishes.
+    ///              For `.stayOpen` behavior, this is called while the open animation is running.
     ///   - label: The view displayed in the revealed area during the swipe.
     public func swipeAction<Label: View>(
         backgroundColor: Color,

Core/Core/Common/Extensions/Foundation/DateExtensions.swift

@@ -192,6 +192,15 @@ public extension Date {
         return formatter
     }()
 
+    /**
+     This date formatter displays abbreviated month names. E.g.: Jan, Feb, Mar.
+     */
+    private static var monthFormatterAbbreviated: DateFormatter = {
+        let formatter = DateFormatter()
+        formatter.setLocalizedDateFormatFromTemplate("MMM")
+        return formatter
+    }()
+
     /**
      This date formatter displays the full month name and the day of the month. E.g.: September 6.
      */
@@ -304,6 +313,13 @@ public extension Date {
         Date.weekdayFormatterAbbreviated.string(from: self)
     }
 
+    /**
+     E.g.: Jan, Feb, Mar
+     */
+    var monthNameAbbreviated: String {
+        Date.monthFormatterAbbreviated.string(from: self)
+    }
+
     /**
      E.g.: September 6.
      */

Core/Core/Common/Extensions/Foundation/NotificationCenterExtensions.swift

@@ -26,6 +26,7 @@ extension NSNotification.Name {
     public static let showGradesOnDashboardDidChange = Notification.Name("com.instructure.core.notification.showGradesOnDashboardDidChange")
     public static let favoritesDidChange = Notification.Name("course-favorite-change")
     public static let windowUserInterfaceStyleDidChange = Notification.Name("com.instructure.core.notification.windowUserInterfaceStyleDidChange")
+    public static let plannerItemDidChange = Notification.Name("com.instructure.core.notification.plannerItemDidChange")
 }
 
 extension NotificationCenter {

Core/Core/Features/Courses/GetCourses.swift

@@ -68,7 +68,7 @@ public class GetCourse: APIUseCase {
     }
 }
 
-public class GetCourses: CollectionUseCase {
+public class GetCourses: APIUseCase {
     public typealias Model = Course
     public typealias Response = GetCoursesRequest.Response
 
@@ -108,6 +108,27 @@ public class GetCourses: CollectionUseCase {
         self.enrollmentState = enrollmentState
         self.perPage = perPage
     }
+
+    public func write(response: GetCoursesRequest.Response?, urlResponse _: URLResponse?, to client: NSManagedObjectContext) {
+        guard let response else { return }
+
+        Self.deleteCoursesNotInResponse(response, scope: scope, in: client)
+
+        response.forEach {
+            Course.save($0, in: client)
+        }
+    }
+
+    public static func deleteCoursesNotInResponse(
+        _ response: [APICourse],
+        scope: Scope,
+        in context: NSManagedObjectContext
+    ) {
+        let idsToKeep = Set(response.map { $0.id.value })
+        let existingCourses: [Course] = context.fetch(scope: scope)
+        let coursesToDelete = existingCourses.filter { !idsToKeep.contains($0.id) }
+        context.delete(coursesToDelete)
+    }
 }
 
 public class GetAllCourses: CollectionUseCase {

Core/Core/Features/Dashboard/CourseCardList/Model/UseCase/GetDashboardCourses.swift

@@ -19,7 +19,7 @@
 import CoreData
 import Foundation
 
-public class GetDashboardCourses: CollectionUseCase {
+public class GetDashboardCourses: APIUseCase {
     public typealias Model = Course
 
     public var cacheKey: String? { "get-dashboard-courses-\(enrollmentState)" }
@@ -45,11 +45,11 @@ public class GetDashboardCourses: CollectionUseCase {
 
     public func write(response: [APICourse]?, urlResponse _: URLResponse?, to client: NSManagedObjectContext) {
         guard let response else { return }
+
+        GetCourses.deleteCoursesNotInResponse(response, scope: scope, in: client)
+
         response.forEach {
-            Course.save(
-                $0,
-                in: client
-            )
+            Course.save($0, in: client)
         }
     }
 }

Core/Core/Features/Planner/CalendarEvent/Model/UseCase/CreateCalendarEvent.swift

@@ -59,5 +59,6 @@ final class CreateCalendarEvent: APIUseCase {
         guard let response else { return }
 
         CalendarEvent.save(response, in: client)
+        NotificationCenter.default.post(name: .plannerItemDidChange, object: nil)
     }
 }

Core/Core/Features/Planner/CalendarEvent/Model/UseCase/DeleteCalendarEvent.swift

@@ -39,4 +39,9 @@ final class DeleteCalendarEvent: DeleteUseCase {
             body: .init(which: seriesModificationType)
         )
     }
+
+    func write(response: Response?, urlResponse: URLResponse?, to client: NSManagedObjectContext) {
+        client.delete(client.fetch(scope: scope) as [Model])
+        NotificationCenter.default.post(name: .plannerItemDidChange, object: nil)
+    }
 }

Core/Core/Features/Planner/CalendarEvent/Model/UseCase/UpdateCalendarEvent.swift

@@ -63,5 +63,6 @@ final class UpdateCalendarEvent: APIUseCase {
         guard let response else { return }
 
         CalendarEvent.save(response, in: client)
+        NotificationCenter.default.post(name: .plannerItemDidChange, object: nil)
     }
 }

Core/Core/Features/Planner/CalendarToDo/Model/UseCase/CreatePlannerNote.swift

@@ -54,5 +54,6 @@ final class CreatePlannerNote: APIUseCase {
         guard let response else { return }
 
         Plannable.save(response, contextName: courseName, in: client)
+        NotificationCenter.default.post(name: .plannerItemDidChange, object: nil)
     }
 }