Skip to content

Commit 58765ab

Browse files
jgu222igcbot
authored andcommitted
Minor change to 3rd NoMask WA
Make sure to use anyh whenever possible. As 3rd version is off. This change has no functional impact.
1 parent 6683d96 commit 58765ab

File tree

1 file changed

+5
-24
lines changed

1 file changed

+5
-24
lines changed

visa/Optimizer.cpp

Lines changed: 5 additions & 24 deletions
Original file line numberDiff line numberDiff line change
@@ -14111,22 +14111,6 @@ void Optimizer::applyNoMaskWA()
1411114111

1411214112
// I0: (W&flagVar) mov (1|M0) r10.0<1>:f WATemp:f
1411314113
const RegionDesc* regionSave = builder.createRegionDesc(I->getExecSize(), HS, 1, 0);
14114-
#if 0
14115-
if (I->getExecSize() == g4::SIMD1) {
14116-
regionSave = ScalarReg;
14117-
}
14118-
else {
14119-
switch (HS)
14120-
{
14121-
case 1: regionSave = builder.getRegionStride1(); break;
14122-
case 2: regionSave = builder.getRegionStride2(); break;
14123-
case 4: regionSave = builder.getRegionStride4(); break;
14124-
default:
14125-
assert(false && "ICE: unsupported dst horz stride!");
14126-
}
14127-
}
14128-
#endif
14129-
1413014114
auto nextII = std::next(aII);
1413114115
G4_SrcRegRegion* I0_src0 = builder.createSrc(WATempVar, 0, 0, regionSave, dst->getType());
1413214116
G4_INST* I0 = builder.createMov(I->getExecSize(), dst, I0_src0, InstOpt_WriteEnable, false);
@@ -14406,15 +14390,12 @@ void Optimizer::applyNoMaskWA()
1440614390
if (isCandidate(I))
1440714391
{
1440814392
waInsts.push_back(II);
14409-
}
1441014393

14411-
if ((I->getExecSize() + I->getMaskOffset()) > 16)
14412-
{
14413-
WATy = Type_UD;
14414-
}
14415-
if (UseAnyh)
14416-
{
14417-
if (I->getExecSize() > Simdsize || I->getMaskOffset() != 0)
14394+
if ((I->getExecSize() + I->getMaskOffset()) > 16)
14395+
{
14396+
WATy = Type_UD;
14397+
}
14398+
if (UseAnyh && (I->getExecSize() > Simdsize || I->getMaskOffset() != 0))
1441814399
{
1441914400
UseAnyh = false;
1442014401
}

0 commit comments

Comments
 (0)