Skip to content

Commit 9cd2944

Browse files
etiottoCopilot
andauthored
Apply suggestions from code review
Co-authored-by: Copilot <[email protected]>
1 parent 1999a52 commit 9cd2944

File tree

1 file changed

+9
-1
lines changed

1 file changed

+9
-1
lines changed

third_party/intel/lib/TritonIntelGPUToLLVM/LoadStoreOpToLLVM.cpp

Lines changed: 9 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -376,6 +376,14 @@ struct BlockIOConversionBase : public LoadStoreConversionBase {
376376
}
377377

378378
// Returns the pitch (stride in bytes) of \p ptr.
379+
//
380+
// \param rewriter The pattern rewriter to use.
381+
// \param ptr The pointer value whose pitch is to be computed.
382+
// \param elemSizeInBits The size of each element in bits.
383+
// \param dim The dimension along which to compute the pitch (stride).
384+
// The default value is 0, which typically refers to the first (innermost) dimension.
385+
// Use the default when you want the pitch for the first dimension; specify another
386+
// value if you need the pitch for a different dimension.
379387
Value getPitch(ConversionPatternRewriter &rewriter, Value ptr,
380388
unsigned elemSizeInBits, unsigned dim = 0) const {
381389
Location loc = ptr.getLoc();
@@ -2298,7 +2306,7 @@ struct LoadOpToBlockIOConversion
22982306
.second;
22992307
Value val = b.extract_element(unpackedVal, b.i32_val(i));
23002308

2301-
// TODO: this is another implementation for othterElems, which is with
2309+
// TODO: this is another implementation for otherElems, which is with
23022310
// more `select` ops but less register pressure. Need to compare the
23032311
// impact of the two implementations.
23042312
// if (otherElems.size()) {

0 commit comments

Comments
 (0)