[SYCL] Kernel free function num args functionality #19517

dklochkov-emb · 2025-07-18T17:30:59Z

This PR adds possibility to get kernel free function number of arguments according to docs
Tests were added according to test plan.

…tion

…-num-args

clang/lib/Sema/SemaSYCL.cpp

sycl/include/sycl/kernel.hpp

sycl/include/sycl/kernel_bundle.hpp

steffenlarsen

I am confident that once my last few comments have been addressed, I am happy with this!

sycl/source/detail/kernel_impl.hpp

sycl/source/detail/kernel_global_info.cpp

sycl/source/detail/program_manager/program_manager.cpp

sycl/source/detail/program_manager/program_manager.hpp

…-num-args

dklochkov-emb · 2025-07-28T15:09:16Z

@intel/dpcpp-cfe-reviewers @premanandrao @elizabethandrews @Fznamznon please, review it

premanandrao

Couple of minor formatting comments, but otherwise, looks good to me.

clang/lib/Sema/SemaSYCL.cpp

clang/test/CodeGenSYCL/free_function_default_template_arguments.cpp

…-num-args

premanandrao

Thank you, LGTM

dklochkov-emb · 2025-07-31T07:22:17Z

@intel/llvm-gatekeepers could you merge it, please?

This PR adds possibility to get kernel free function number of arguments according to [docs](https://github.com/intel/llvm/blob/sycl/sycl/doc/extensions/proposed/sycl_ext_oneapi_free_function_kernels.asciidoc#behavior-with-kernel-bundle-functions-in-the-core-sycl-specification) Tests were added according to test plan.

This is a cherry-pick of #19517 This PR adds possibility to get kernel free function number of arguments according to [docs](https://github.com/intel/llvm/blob/sycl/sycl/doc/extensions/proposed/sycl_ext_oneapi_free_function_kernels.asciidoc#behavior-with-kernel-bundle-functions-in-the-core-sycl-specification) Tests were added according to test plan. Patch-by: dklochkov-intel <[email protected]>

dklochkov-emb added 2 commits July 18, 2025 19:24

[SYCL] add possibility to get number of argumnet of kernell free func…

15555b7

…tion

[SYCL] update formatting

e954028

dklochkov-emb self-assigned this Jul 18, 2025

dklochkov-emb requested review from a team as code owners July 18, 2025 17:31

dklochkov-emb requested a review from steffenlarsen July 18, 2025 17:31

dklochkov-emb had a problem deploying to WindowsCILock July 18, 2025 17:31 — with GitHub Actions Error

dklochkov-emb requested a review from AlexeySachkov July 18, 2025 17:31

[SYCL] do no capture unused parameters in lambda

ecfea21

dklochkov-emb had a problem deploying to WindowsCILock July 18, 2025 17:42 — with GitHub Actions Failure

dklochkov-emb mentioned this pull request Jul 18, 2025

[SYCL] tests of kernel bundle after adding kernel free function #19518

Merged

dklochkov-emb had a problem deploying to WindowsCILock July 18, 2025 18:12 — with GitHub Actions Failure

[SYCL][E2E] update win abi test

c0f2b29

dklochkov-emb temporarily deployed to WindowsCILock July 18, 2025 18:22 — with GitHub Actions Inactive

dklochkov-emb had a problem deploying to WindowsCILock July 18, 2025 18:58 — with GitHub Actions Failure

Merge remote-tracking branch 'upstream/sycl' into sycl-free-functions…

6eb351e

…-num-args

dklochkov-emb temporarily deployed to WindowsCILock July 21, 2025 07:12 — with GitHub Actions Inactive

dklochkov-emb had a problem deploying to WindowsCILock July 21, 2025 07:55 — with GitHub Actions Failure

[SYCL] return free function kernel data only if kernel is free function

cdc214c

dklochkov-emb had a problem deploying to WindowsCILock July 21, 2025 11:43 — with GitHub Actions Error

[SYCL] fix formatting

a3e9450

dklochkov-emb had a problem deploying to WindowsCILock July 21, 2025 11:58 — with GitHub Actions Failure

dklochkov-emb temporarily deployed to WindowsCILock July 21, 2025 12:37 — with GitHub Actions Inactive

dklochkov-emb had a problem deploying to WindowsCILock July 21, 2025 12:37 — with GitHub Actions Failure

[SYCL][TEST] update ABI tests

2373446

dklochkov-emb temporarily deployed to WindowsCILock July 21, 2025 12:46 — with GitHub Actions Inactive

steffenlarsen reviewed Jul 21, 2025

View reviewed changes

dklochkov-emb had a problem deploying to WindowsCILock July 24, 2025 11:21 — with GitHub Actions Error

[SYCL][TEST] update win abi test

0b67f11

dklochkov-emb temporarily deployed to WindowsCILock July 24, 2025 11:25 — with GitHub Actions Inactive

dklochkov-emb temporarily deployed to WindowsCILock July 24, 2025 11:58 — with GitHub Actions Inactive

steffenlarsen approved these changes Jul 24, 2025

View reviewed changes

[SYCL] more informative names and comments

532aff0

dklochkov-emb temporarily deployed to WindowsCILock July 24, 2025 12:58 — with GitHub Actions Inactive

dklochkov-emb had a problem deploying to WindowsCILock July 24, 2025 13:28 — with GitHub Actions Error

Merge remote-tracking branch 'upstream/sycl' into sycl-free-functions…

b52a1b3

…-num-args

dklochkov-emb temporarily deployed to WindowsCILock July 24, 2025 13:33 — with GitHub Actions Inactive

dklochkov-emb temporarily deployed to WindowsCILock July 24, 2025 14:04 — with GitHub Actions Inactive

premanandrao reviewed Jul 28, 2025

View reviewed changes

clang/lib/Sema/SemaSYCL.cpp Outdated Show resolved Hide resolved

clang/test/CodeGenSYCL/free_function_default_template_arguments.cpp Outdated Show resolved Hide resolved

dklochkov-emb added 2 commits July 29, 2025 01:47

[SYCL] update formatting

be6f64c

Merge remote-tracking branch 'upstream/sycl' into sycl-free-functions…

80271f0

…-num-args

dklochkov-emb temporarily deployed to WindowsCILock July 29, 2025 08:50 — with GitHub Actions Inactive

dklochkov-emb requested a review from premanandrao July 29, 2025 08:50

dklochkov-emb temporarily deployed to WindowsCILock July 29, 2025 09:20 — with GitHub Actions Inactive

premanandrao reviewed Jul 30, 2025

View reviewed changes

premanandrao approved these changes Jul 30, 2025

View reviewed changes

sergey-semenov merged commit 464871d into intel:sycl Jul 31, 2025
25 checks passed

AlexeySachkov mentioned this pull request Aug 25, 2025

[SYCL] Kernel free function num args functionality #19868

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[SYCL] Kernel free function num args functionality #19517

[SYCL] Kernel free function num args functionality #19517

Uh oh!

dklochkov-emb commented Jul 18, 2025 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

steffenlarsen left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

dklochkov-emb commented Jul 28, 2025 •

edited

Loading

Uh oh!

premanandrao left a comment

Uh oh!

Uh oh!

Uh oh!

premanandrao left a comment

Uh oh!

dklochkov-emb commented Jul 31, 2025

Uh oh!

Uh oh!

Uh oh!

[SYCL] Kernel free function num args functionality #19517

[SYCL] Kernel free function num args functionality #19517

Uh oh!

Conversation

dklochkov-emb commented Jul 18, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

steffenlarsen left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

dklochkov-emb commented Jul 28, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

premanandrao left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

premanandrao left a comment

Choose a reason for hiding this comment

Uh oh!

dklochkov-emb commented Jul 31, 2025

Uh oh!

Uh oh!

Uh oh!

dklochkov-emb commented Jul 18, 2025 •

edited

Loading

dklochkov-emb commented Jul 28, 2025 •

edited

Loading