Comment re: use of WQM

isc-tleavitt · isc-tleavitt · commit 010910712182 · 2023-05-18T10:24:12.000-04:00
diff --git a/cls/SourceControl/Git/Settings.cls b/cls/SourceControl/Git/Settings.cls
@@ -119,6 +119,7 @@ Method OnAfterConfigure() As %Boolean
         }
         if value {
             #dim workMgr As %SYSTEM.AbstractWorkMgr
+             // using work queue manager ensures proper OS user context when running ssh-keygen
             set workMgr = $System.WorkMgr.%New("")
             $$$ThrowOnError(workMgr.Queue("##class(SourceControl.Git.Utils).GenerateSSHKeyPair"))
             $$$ThrowOnError(workMgr.Sync())
@@ -146,6 +147,7 @@ Method OnAfterConfigure() As %Boolean
             }
         }
         if (value = 1) {
+             // using work queue manager ensures proper OS user context/file ownership
             set workMgr = $System.WorkMgr.%New("")
             $$$ThrowOnError(workMgr.Queue("##class(SourceControl.Git.Utils).Init"))
             $$$ThrowOnError(workMgr.Sync())
@@ -157,6 +159,7 @@ Method OnAfterConfigure() As %Boolean
             if (remote = "") {
                 quit
             }
+             // using work queue manager ensures proper OS user context/file ownership
             set workMgr = $System.WorkMgr.%New("")
             $$$ThrowOnError(workMgr.Queue("##class(SourceControl.Git.Utils).Clone",remote))
             $$$ThrowOnError(workMgr.Sync())

Original file line number	Diff line number	Diff line change
`@@ -119,6 +119,7 @@ Method OnAfterConfigure() As %Boolean`
`119`	`119`	`}`
`120`	`120`	`if value {`
`121`	`121`	`#dim workMgr As %SYSTEM.AbstractWorkMgr`
	`122`	`+ // using work queue manager ensures proper OS user context when running ssh-keygen`
`122`	`123`	`set workMgr = $System.WorkMgr.%New("")`
`123`	`124`	`$$$ThrowOnError(workMgr.Queue("##class(SourceControl.Git.Utils).GenerateSSHKeyPair"))`
`124`	`125`	`$$$ThrowOnError(workMgr.Sync())`
`@@ -146,6 +147,7 @@ Method OnAfterConfigure() As %Boolean`
`146`	`147`	`}`
`147`	`148`	`}`
`148`	`149`	`if (value = 1) {`
	`150`	`+ // using work queue manager ensures proper OS user context/file ownership`
`149`	`151`	`set workMgr = $System.WorkMgr.%New("")`
`150`	`152`	`$$$ThrowOnError(workMgr.Queue("##class(SourceControl.Git.Utils).Init"))`
`151`	`153`	`$$$ThrowOnError(workMgr.Sync())`
`@@ -157,6 +159,7 @@ Method OnAfterConfigure() As %Boolean`
`157`	`159`	`if (remote = "") {`
`158`	`160`	`quit`
`159`	`161`	`}`
	`162`	`+ // using work queue manager ensures proper OS user context/file ownership`
`160`	`163`	`set workMgr = $System.WorkMgr.%New("")`
`161`	`164`	`$$$ThrowOnError(workMgr.Queue("##class(SourceControl.Git.Utils).Clone",remote))`
`162`	`165`	`$$$ThrowOnError(workMgr.Sync())`