Fix: don't call $$CheckProtect for user types

isc-tleavitt · isc-tleavitt · commit 66a806059004 · 2023-01-17T13:30:28.000-05:00
Always returns true for e.g. Ens.Config.DefaultSettings.ESD
diff --git a/cls/SourceControl/Git/Utils.cls b/cls/SourceControl/Git/Utils.cls
@@ -1465,7 +1465,7 @@ ClassMethod Name(InternalName As %String, ByRef MappingExists As %Boolean) As %S
         }
     }
     
-    if $$CheckProtect^%qccServer(InternalName) {
+    if '##class(%Library.RoutineMgr).UserType(InternalName) && $$CheckProtect^%qccServer(InternalName) {
         quit ""
     }
        
@@ -1881,4 +1881,3 @@ ClassMethod BuildCEInstallationPackage(ByRef destination As %String) As %Status
 }
 
 }
-

Original file line number	Diff line number	Diff line change
`@@ -1465,7 +1465,7 @@ ClassMethod Name(InternalName As %String, ByRef MappingExists As %Boolean) As %S`
`1465`	`1465`	`}`
`1466`	`1466`	`}`
`1467`	`1467`
`1468`		`- if $$CheckProtect^%qccServer(InternalName) {`
	`1468`	`+ if '##class(%Library.RoutineMgr).UserType(InternalName) && $$CheckProtect^%qccServer(InternalName) {`
`1469`	`1469`	`quit ""`
`1470`	`1470`	`}`
`1471`	`1471`
`@@ -1881,4 +1881,3 @@ ClassMethod BuildCEInstallationPackage(ByRef destination As %String) As %Status`
`1881`	`1881`	`}`
`1882`	`1882`
`1883`	`1883`	`}`
`1884`		`-`