Skip to content

Commit 1ff26b7

Browse files
authored
chore(github-actions): fine tune workflow permissions (#30791)
Issue number: resolves # --------- <!-- Please do not submit updates to dependencies unless it fixes an issue. --> <!-- Please try to limit your pull request to one type (bugfix, feature, etc). Submit multiple pull requests if needed. --> ## What is the current behavior? <!-- Please describe the current behavior that you are modifying. --> - Permissions not set as expected ## What is the new behavior? <!-- Please describe the behavior or changes that are being added by this PR. --> - Permissions are properly set throughout the hierarchy ## Does this introduce a breaking change? - [ ] Yes - [x] No <!-- If this introduces a breaking change: 1. Describe the impact and migration path for existing applications below. 2. Update the BREAKING.md file with the breaking change. 3. Add "BREAKING CHANGE: [...]" to the commit description when merging. See https://github.com/ionic-team/ionic-framework/blob/main/docs/CONTRIBUTING.md#footer for more information. --> ## Other information <!-- Any other information that is important to this PR such as screenshots of how the component looks before and after the change. -->
1 parent 99bfdee commit 1ff26b7

File tree

2 files changed

+10
-0
lines changed

2 files changed

+10
-0
lines changed

.github/workflows/nightly.yml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -34,6 +34,7 @@ jobs:
3434
contents: read
3535
id-token: write
3636
uses: ./.github/workflows/release-ionic.yml
37+
secrets: inherit
3738
with:
3839
tag: nightly
3940
version: ${{ needs.create-nightly-hash.outputs.nightly-hash }}

.github/workflows/release-orchestrator.yml

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -55,16 +55,25 @@ permissions:
5555
jobs:
5656
run-nightly:
5757
if: ${{ github.event_name == 'schedule' || (github.event_name == 'workflow_dispatch' && inputs.release-type == 'nightly') }}
58+
permissions:
59+
contents: read
60+
id-token: write
5861
uses: ./.github/workflows/nightly.yml
5962
secrets: inherit
6063

6164
run-dev:
6265
if: ${{ github.event_name == 'workflow_dispatch' && inputs.release-type == 'dev' }}
66+
permissions:
67+
contents: read
68+
id-token: write
6369
uses: ./.github/workflows/dev-build.yml
6470
secrets: inherit
6571

6672
run-production:
6773
if: ${{ github.event_name == 'workflow_dispatch' && inputs.release-type == 'production' }}
74+
permissions:
75+
contents: read
76+
id-token: write
6877
uses: ./.github/workflows/release.yml
6978
secrets: inherit
7079
with:

0 commit comments

Comments
 (0)