Merge pull request #53 from iroy2000/make-webpack-config-more-easy-to-reason

Make webpack config more easy to reason

Author: iroy2000

.eslintrc

@@ -31,6 +31,7 @@
     "react/prop-types": 0,
     "react/jsx-filename-extension": 0,
     "comma-dangle": [2, "always-multiline"],
+    "arrow-parens": ["warn", "always"],
     "jsx-a11y/anchor-is-valid": [ "error", {
         "components": [ "Link" ],
         "specialLink": [ "to", "hrefLeft", "hrefRight" ],

bin/commands.js

@@ -5,21 +5,17 @@ const colors = require('colors');
 const host = config.get('host') || 'localhost';
 const port = config.get('port') || '8080';
 
-console.log('using settings:');
-console.log('\thost:', host);
-console.log('\tport:', port);
-
 const option = process.argv[2];
 
 switch (option) {
   case 'lint':
     shell.exec('cross-env eslint src/js/** server/** --format node_modules/eslint-friendly-formatter . --ext .js --ext .jsx  --cache; exit 0');
     break;
   case 'dev':
-    shell.exec(`cross-env HOST=${host} PORT=${port} webpack-dev-server --hot --progress --no-info --inline --colors --content-base ./docroot`);
+    shell.exec(`cross-env HOST=${host} PORT=${port} webpack-dev-server --config webpack.config.dev-server.babel.js --hot --progress --no-info --inline --colors --content-base ./docroot`);
     break;
   case 'build':
-    shell.exec(`cross-env rimraf docroot && webpack --progress --display-error-details`);
+    shell.exec(`cross-env rimraf docroot && webpack --config webpack.config.build.babel.js --progress --display-error-details`);
     break;
   default:
     // If the app type is invalid, stop execution of the file.

bin/shouldBuild.js

@@ -2,6 +2,8 @@
   "env": "default",
   "host": "localhost",
   "port": "8080",
+  "publicPath": "/",
+  "assetPath": "assets",
   "jsSourcePath": "src/js",
   "s3": {
     "s3Deploy": false,

bin/start.js

@@ -2,6 +2,6 @@
   "env": "development",
   "app": {
     "description": "you can overwrite the default config",
-    "hello": "Config is configurable"
+    "hello": "You are in local development mode"
   }
 }

config/default.json

@@ -1,4 +1,4 @@
 {
   "env": "production",
-  "publicPath": "./"
+  "publicPath": "/"
 }

config/development.json

@@ -5,7 +5,7 @@
   "scripts": {
     "dev": "cross-env NODE_ENV=development DASHBOARD_PORT=9901 webpack-dashboard -p 9901 -c red -t dashboard -- node bin/commands.js dev",
     "build": "cross-env NODE_ENV=production node bin/commands.js build",
-    "build:release": "cross-env NODE_ENV=release node bin/commands.js build",
+    "build:stage": "cross-env NODE_ENV=stage node bin/commands.js build",
     "clean": "rimraf docroot",
     "test": "jest --no-cache",
     "lint": "node bin/commands.js lint"