Skip to content

python 3 compatibility #24

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

python 3 compatibility #24

wants to merge 1 commit into from

Conversation

@StephenC19
Copy link

@StephenC19 StephenC19 commented Nov 20, 2021 •
edited
Loading

I recently used this for a small project I was working on but wanted to run with python3.

Changes include:

  • Adding brackets to print statements
  • Converting dict objects to lists for adding to SQL queries
  • Updated requirements.txt
  • Newer version of Reader lib

mohammedElfatihSalah
mohammedElfatihSalah suggested changes Dec 28, 2021
View reviewed changes
Copy link

@mohammedElfatihSalah mohammedElfatihSalah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you didnot sumbmitted reader.py?

@kheyrem
Copy link

kheyrem commented Jun 6, 2023

still not working for me the project

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@mohammedElfatihSalah mohammedElfatihSalah mohammedElfatihSalah requested changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@StephenC19 @kheyrem @mohammedElfatihSalah