Not providing fullNameOverride to minecraft chart is failing helm deployment

[janpfischer]

I tried to upgrade from 1.24 to 1.26. With 1.25 and #252 and #253 a feature was added to override the generated names for the resources.

I have not specified a fullNameOverride in my values.yaml and am now getting the following error when trying to upgrade to 1.26:

'Helm upgrade failed for release selfhosted/minecraft with chart minecraft@4.26.1:
      template: minecraft/templates/_helpers.tpl:32:14: executing "minecraft.fullname"
      at <.Values.fullnameOverride>: nil pointer evaluating interface {}.fullnameOverride'

[itzg]

@joryirving can you help look at this?

[joryirving]

Interesting. Can you post your values file? I can't reproduce, as it works for me without defining fullnameOverride

[janpfischer]

Sure. This are the values. Deployed via Flux HelmRelease resource:

values:
    deploymentAnnotations:
      secret.reloader.stakater.com/reload: &secret minecraft-secret
    image:
      repository: itzg/minecraft-server
      tag: 2025.4.0-java21
    resources:
      limits:
        cpu: 2000m
        memory: 4000Mi
      requests:
        cpu: 200m
        memory: 2000Mi
    securityContext:
      runAsUser: ${APP_UID}
      fsGroup: ${APP_GID}
    livenessProbe:
      initialDelaySeconds: 0
    readinessProbe:
      initialDelaySeconds: 0
    startupProbe:
      enabled: true
    extraEnv:
      ENABLE_ROLLING_LOGS: true
      MEMORY: ""
    persistence:
      dataDir:
        enabled: true
        existingClaim: minecraft-data
    serviceAnnotations:
      cert-manager.io/cluster-issuer: letsencrypt-production
      io.cilium/lb-ipam-ips: ****
      coredns.io/hostname: minecraft-server.${SECRET_DOMAIN}
    minecraftServer:
      eula: true
      version: 1.21.4
      type: PAPER
      difficulty: normal
      pvp: true
      whitelist: ****
      ops: ****
      motd: Meh
      worldSaveName: world
      viewDistance: 12
      forceReDownload: true
      memory: ""
      jvmXXOpts: "-XX:MaxRAMPercentage=70"
      rcon:
        enabled: true
        serviceType: ClusterIP
      serviceType: LoadBalancer
      extraPorts:
        - name: map
          containerPort: 8100
          protocol: TCP
          service:
            enabled: true
            embedded: false
            type: ClusterIP
            port: 8100
          ingress:
            ingressClassName: external
            enabled: true
            hosts:
              - name: &host minecraft.${SECRET_DOMAIN}
                path: /
            tls: [hosts: [*host]]
  valuesFrom:
    - kind: Secret
      name: *secret
      valuesKey: RCON_PASSWORD
      targetPath: minecraftServer.rcon.password

[joryirving]

Okay, so I tried to recreate using your HR:
https://github.com/joryirving/home-ops/blob/f331993941bc66da3c8df8fbb5c1db01a3dd7c48/kubernetes/apps/base/games/minecraft/testcraft/helmrelease.yaml

But it appears to just work for me:

home-ops [󱃾 main (flux-system)] on  main (f3319939) 
❯ k get hr -n games minecraft-testcraft
NAME                  AGE   READY   STATUS
minecraft-testcraft   19h   True    Helm upgrade succeeded for release games/minecraft-testcraft.v2 with chart minecraft@4.26.1

home-ops [󱃾 main (flux-system)] on  main (f3319939) 
❯ k get pods -n games | grep testcraft
minecraft-testcraft-84448cbb47-8zrwt   1/1     Running   0             103s

[joryirving]

Opened a PR just for a catch on nil values. Hopefully it should help.

[janpfischer]

The error message slightly changed. It is now an error for another field:

'Helm upgrade failed for release selfhosted/minecraft with chart minecraft@4.26.2:                                                                                                                    │
│       template: minecraft/templates/_helpers.tpl:36:27: executing "minecraft.fullname"                                                                                                                             │
│       at <.Chart.Name>: nil pointer evaluating interface {}.Name'

Also flux local is throwing an error when diffing locally:

Run if [[ "helmrelease" == "helmrelease" ]]; then
WARNING:flux_local.values:Unable to find SubstituteReference for flux-system/cluster: cluster-settings
WARNING:flux_local.values:Unable to find SubstituteReference for flux-system/cluster-apps: cluster-settings
WARNING:flux_local.values:Unable to find Secret selfhosted/minecraft-secret referenced
WARNING:flux_local.values:Unable to find SubstituteReference for flux-system/cluster: cluster-settings
WARNING:flux_local.values:Unable to find SubstituteReference for flux-system/cluster-apps: cluster-settings
WARNING:flux_local.values:Unable to find Secret selfhosted/minecraft-secret referenced
INFO:flux_local.resource_diff:HelmRelease selfhosted/minecraft detected potential change in resource selfhosted/minecraft (Kustomization flux-system/cluster-apps-minecraft)
flux-local error:  Command 'helm template minecraft flux-system-minecraft-server/minecraft --namespace selfhosted --repository-cache /tmp/tmpx63ovip7 --repository-config /tmp/tmpm3vtxmkh/repository-config.yaml --registry-config /dev/null --skip-crds --skip-tests --api-versions policy/v1/PodDisruptionBudget --version 4.26.2 --values /tmp/tmpm3vtxmkh/selfhosted-minecraft-values.yaml' failed with return code 1
Error: template: minecraft/templates/_helpers.tpl:36:27: executing "minecraft.fullname" at <.Chart.Name>: nil pointer evaluating interface {}.Name

[itzg]

Hmm, there must be some other factors going on. @janpfischer whats your helm version? Maybe make sure to match that up @joryirving in your cross check.

[joryirving]

What do you set for your name in your hr? Can you share the full HR or compare it to the one I posted?

[mxtw]

I have the same issue whenever I add an extraPort with ingress.enabled: true

[janpfischer]

Thanks @mxtw, that fixed it for me too. I had extraPorts enabled, too.
Thanks @joryirving and @itzg for your support, too!