Remove variables to check defaults (NETWAYS#148)

* Remove variables to check defaults
* Failsafe for conditional

fixes NETWAYS#4

Author: widhalmt

molecule/full_stack-oss/converge.yml

@@ -12,11 +12,9 @@
 - name: Converge
   hosts: all
   vars:
-    logstash_enable: true
-    logstash_security: true
-    elasticsearch_security: false
     elastic_stack_full_stack: true
     elastic_variant: oss
+    logstash_security: false
     elastic_security: false
     filebeat_syslog_udp: true
     filebeat_syslog_tcp: true

molecule/full_stack/converge.yml

@@ -6,8 +6,6 @@
 - name: Converge
   hosts: all
   vars:
-    logstash_enable: true
-    logstash_security: true
     elastic_stack_full_stack: true
     filebeat_syslog_udp: true
     filebeat_syslog_tcp: true

tasks/main.yml

@@ -55,7 +55,7 @@
   import_tasks: logstash-security.yml
   when:
   - elastic_stack_full_stack | bool
-  - logstash_security | bool
+  - logstash_security is defined and logstash_security | bool
   - elastic_variant == "elastic"
   tags:
   - security

templates/elasticsearch-output.conf.j2

@@ -21,7 +21,7 @@ filter {
 output {
   elasticsearch {
     hosts => [ {% for host in logstash_elasticsearch %}"{{ host }}:9200"{% if not loop.last %},{% endif %}{% endfor %}]
-{% if elastic_stack_full_stack | bool and logstash_security | bool and elastic_variant == "elastic" %}
+{% if elastic_stack_full_stack | bool and logstash_security is defined and logstash_security | bool and elastic_variant == "elastic" %}
     keystore => "{{ logstash_certs_dir }}/keystore.pfx"
     keystore_password => "{{ logstash_tls_key_passphrase }}"
     cacert => "{{ logstash_certs_dir }}/ca.crt"