Skip to content

Commit 2756457

Browse files
committed
Merge branch 'develop'
2 parents a621db8 + 76a07db commit 2756457

File tree

5 files changed

+14
-23
lines changed

5 files changed

+14
-23
lines changed

appveyor.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
os: Visual Studio 2015
22

33
# Version format
4-
version: 0.1.0.{build}
4+
version: 0.1.1.{build}
55

66
cache:
77
- src\packages -> **\packages.config # preserve "packages" directory in the root of build folder but will reset it if packages.config is modified

docs/Usage.md

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@ Here are sample usages of the currently supported property editors. You are not
1616
- **Supported values**:
1717
- **Vertical**: top, center & bottom
1818
- **Horizontal**: left, center & right
19-
- **Editor**: 3 × 3 grid
19+
- **Editor**: 3×3 grid
2020

2121
```json
2222
...
@@ -62,8 +62,8 @@ Here are sample usages of the currently supported property editors. You are not
6262
```json
6363
...
6464
{
65-
"label": "Set background repetition",
66-
"description": "Set background repetition",
65+
"label": "Set background size",
66+
"description": "Set background size",
6767
"key": "background-size",
6868
"view": "/App_Plugins/Our.Umbraco.GridSettings/editors/BackgroundSize/view.html"
6969
}
@@ -72,9 +72,9 @@ Here are sample usages of the currently supported property editors. You are not
7272

7373
### Color Picker
7474

75-
- **Typical CSS Property**: background-color, color (anything which supports CSS colors)
76-
- **Supported values**: Developer provided prevalues (see below). The value or string must be a valid CSS color value.
77-
- **Editor**: Simple color picker
75+
- **Typical CSS Property**: background-color, color (anything which expects a hexcode color)
76+
- **Supported values**: Developer provided prevalues (see below). The value or string must be a valid hexcode color value. Non-hexcode color values are not supported.
77+
- **Editor**: Simple color picker (reupurposing the Approved Color Picker editor)
7878

7979
**Note**: Prior to v7.5.4 grid prevalues only supported a string array. From v7.5.4+ prevalues support a mixture of label/value objects and strings.
8080

src/Our.Umbraco.GridSettings.Web/App_Plugins/Our.Umbraco.GridSettings/editors/ColorPicker/controller.js

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,15 +1,12 @@
11
(function () {
22
'use strict';
33

4-
var controller = function ($scope, assetsService) {
5-
assetsService.loadCss("/App_Plugins/Our.Umbraco.GridSettings/editors/ColorPicker/view.css");
6-
4+
var controller = function ($scope) {
75
$scope.colors = [];
86

97
for (var prevalueIndex = 0; prevalueIndex < $scope.model.prevalues.length; prevalueIndex++) {
108
var prevalue = $scope.model.prevalues[prevalueIndex];
119

12-
1310
if (typeof (prevalue) === 'string') {
1411
$scope.colors.push({
1512
'label': prevalue,

src/Our.Umbraco.GridSettings.Web/App_Plugins/Our.Umbraco.GridSettings/editors/ColorPicker/view.css

Lines changed: 0 additions & 10 deletions
This file was deleted.
Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,9 @@
11
<div ng-controller="Our.Umbraco.GridSettings.ColorPickerController">
2-
<ul class="gridsettings--colorpicker unstyled">
3-
<li ng-repeat="item in colors" style="background-color: {{item.value}}" ng-class="{'active': isValue(item.value)}" title="{{item.label}}" ng-click="setValue(item.value)"><!-- --></li>
2+
<ul class="thumbnails color-picker">
3+
<li ng-repeat="item in colors" ng-class="{active: isValue(item.value)}" title="{{item.label}}">
4+
<a ng-click="setValue(item.value)" class="thumbnail" hex-bg-color="{{item.value}}">
5+
<!-- -->
6+
</a>
7+
</li>
48
</ul>
59
</div>

0 commit comments

Comments
 (0)