MONGOID-5972 Make persist_atomic_operations public

It is called on _root from touchable and creatable, so it was never
actually private. Move it above the private keyword (keeping the
@api private doc, matching atomic_selector and _root) and drop the
send calls at both cross-object call sites.

Author: jamis

lib/mongoid/persistable.rb

@@ -142,6 +142,21 @@ def fail_due_to_callback!(method)
       raise Errors::Callback.new(self.class, method)
     end
 
+    # Persist the atomic operations.
+    #
+    # @api private
+    #
+    # @example Persist the atomic operations.
+    #   persist_atomic_operations(ops)
+    #
+    # @param [ Hash ] operations The atomic operations.
+    def persist_atomic_operations(operations)
+      return unless persisted? && operations && !operations.empty?
+
+      selector = atomic_selector
+      _root.collection.find(selector).update_one(positionally(selector, operations), session: _session)
+    end
+
     private
 
     # Are we executing an atomically block on the current document?
@@ -300,20 +315,5 @@ def persist_or_delay_atomic_operation(operation)
         persist_atomic_operations(operation)
       end
     end
-
-    # Persist the atomic operations.
-    #
-    # @api private
-    #
-    # @example Persist the atomic operations.
-    #   persist_atomic_operations(ops)
-    #
-    # @param [ Hash ] operations The atomic operations.
-    def persist_atomic_operations(operations)
-      return unless persisted? && operations && !operations.empty?
-
-      selector = atomic_selector
-      _root.collection.find(selector).update_one(positionally(selector, operations), session: _session)
-    end
   end
 end

lib/mongoid/persistable/creatable.rb

@@ -135,7 +135,7 @@ def insert_as_embedded
               positionally(selector, operations),
               session: _session
             )
-            _root.send(:persist_atomic_operations, '$set' => deferred_touches) if deferred_touches
+            _root.persist_atomic_operations('$set' => deferred_touches) if deferred_touches
           rescue StandardError
             # If the insert failed, the after_save callback will not run to
             # consume and clear the merged-touch flag, so clear it here.

lib/mongoid/touchable.rb

@@ -49,7 +49,7 @@ def touch(field = nil)
 
         begin
           touches = _gather_touch_updates(Time.current, field)
-          _root.send(:persist_atomic_operations, '$set' => touches) if touches.present?
+          _root.persist_atomic_operations('$set' => touches) if touches.present?
           _run_touch_callbacks_from_root
         ensure
           _clear_touch_updates(field)