DeduplicateStdioHandles() should inherit

hsfzxjy · hsfzxjy · commit 61d5df6e6d5c · 2025-07-20T00:56:32.000+08:00
The duplicated handles in DeduplicateStdioHandles() should
be inheritable. Otherwise sys_fork_nt_parent() will pass
non-inheritable handles to CreateProcess().
diff --git a/libc/runtime/winmain.greg.c b/libc/runtime/winmain.greg.c
@@ -147,7 +147,7 @@ abi static void DeduplicateStdioHandles(void) {
       int64_t h2 = __imp_GetStdHandle(kNtStdio[j]);
       if (h1 == h2) {
         int64_t h3;
-        __imp_DuplicateHandle(-1, h2, -1, &h3, 0, false,
+        __imp_DuplicateHandle(-1, h2, -1, &h3, 0, true,
                               kNtDuplicateSameAccess);
         __imp_SetStdHandle(kNtStdio[j], h3);
       }

Original file line number	Diff line number	Diff line change
`@@ -147,7 +147,7 @@ abi static void DeduplicateStdioHandles(void) {`
`147`	`147`	`int64_t h2 = __imp_GetStdHandle(kNtStdio[j]);`
`148`	`148`	`if (h1 == h2) {`
`149`	`149`	`int64_t h3;`
`150`		`- __imp_DuplicateHandle(-1, h2, -1, &h3, 0, false,`
	`150`	`+ __imp_DuplicateHandle(-1, h2, -1, &h3, 0, true,`
`151`	`151`	`kNtDuplicateSameAccess);`
`152`	`152`	`__imp_SetStdHandle(kNtStdio[j], h3);`
`153`	`153`	`}`