First attempt at inheritance homework. #3
Conversation
…ttributes bound to each object instead of their constructors.
…methods for Animal and its sub-types.
joshdmiller
left a comment
joshdmiller
left a comment
There was a problem hiding this comment.
Looking pretty good! Aside from the comment on slack about the SOUND bit, I put in a couple comments to bring your code inline with the more "canonical" approach.
src/index.js
Outdated
| this.thumbs = true; | ||
| } | ||
| Primate.SOUND = 'Ooh ooh eee!'; | ||
| Primate.prototype = new Animal(); |
There was a problem hiding this comment.
You're looking for Object.create here. Much cleaner. Otherwise, chlorophyll is defined on the prototype instead of the instance, which isn't in line with what you did with animal. Also see comment above.
src/index.js
Outdated
| Reptile.prototype.constructor = Reptile; | ||
|
|
||
| export function Primate() { | ||
| this.thumbs = true; |
There was a problem hiding this comment.
You'll want to call the Animal constructor within this constructor, and "bind" it to this instance.
|
The diff got outdated as I did the review, so in case you didn't see my other comments, check out the review above. Good work! |
…eate() and made constructors empty.
…me with ES6 classes.
| @@ -1 +1,2 @@ | |||
| node_modules/ | |||
| .idea/ | |||
There was a problem hiding this comment.
<random-thought>
Random comment having nothing to do with this class nor even javascript: you can define a global gitignore file that applies to all repositories, which is a good place for stuff like this. I do it that way so I can omit files that my editor generates without (a) having to change every gitignore in every repo I ever touch; and (b) to prevent committing irrelevant code to repos.
</random-thought>
There was a problem hiding this comment.
I didn't know you could define a global .gitignore across repositories as I mostly just write them per-project. Are you simply just keeping the configurations in a common repository or are you doing any special Github linking between projects?
There was a problem hiding this comment.
No, it's more "set it and forget it". Check out the link from my first comment. You just keep a file on your computer someplace that looks like a gitignore file and you put its location in your configuration for git (can be done from cli too).
src/index.js
Outdated
| export function Human(){} | ||
| Human.SOUND = 'hello'; | ||
| Human.prototype = Object.create(Primate.prototype); | ||
| Human.prototype.speak = function () {return Human.SOUND}; |
There was a problem hiding this comment.
What about:
Human.prototype.speak = function ( message ) { return message; };There was a problem hiding this comment.
I didn't look at the unit test carefully for the human type/ES6 Class and that's why I didn't write it this way. This has been fixed here: https://github.com/synflyn28/js-test-boilerplate/commit/cd1b8ff2c7fa303f975995cab3695a1b9c34cffe.
2 participants
This is my first attempt at our inheritance homework. I have got the inheritance working, however I couldn't figure out how to refer to the "current class constant" for the "speak" method inherited by the other subtypes of "Animal". I got the test suite to work if I referred to the specific instances of those subtypes (humans, primates, and reptiles) but I couldn't get the suite to pass if I referred to their capital letter constructors.