Skip to content

Conversation

ssg
Copy link
Contributor

@ssg ssg commented Jul 19, 2025

This function is giving out deprecation warnings on modern IDEs. Replacing it with more modern and very well-supported alternative.

@Copilot Copilot AI review requested due to automatic review settings July 19, 2025 04:13
Copy link

linux-foundation-easycla bot commented Jul 19, 2025

CLA Signed


The committers listed above are authorized under a signed CLA.

Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR replaces the deprecated substr() method with the modern slice() method to eliminate deprecation warnings in modern IDEs. The change maintains identical functionality while using a more current and well-supported string method.

  • Replace substr(-2) with slice(-2) in hex color string generation
  • Modernize code to avoid deprecation warnings without changing behavior

Copy link
Member

@mgol mgol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@mgol mgol added this to the 3.0.1 milestone Aug 6, 2025
@mgol mgol merged commit 6742ffa into jquery:main Aug 6, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants