Skip to content

Commit 53cffda

Browse files
Swap the argument order of all the insertion methods
The reference node is now first
1 parent 543fb09 commit 53cffda

File tree

2 files changed

+179
-179
lines changed

2 files changed

+179
-179
lines changed

lib/SymbolTree.js

Lines changed: 10 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -675,12 +675,12 @@ class SymbolTree {
675675
*
676676
* @method insertBefore
677677
* @memberOf module:symbol-tree#
678-
* @param {Object} newObject
679678
* @param {Object} referenceObject
679+
* @param {Object} newObject
680680
* @throws {Error} If the newObject is already present in this SymbolTree
681681
* @return {Object} newObject
682682
*/
683-
insertBefore(newObject, referenceObject) {
683+
insertBefore(referenceObject, newObject) {
684684
const referenceNode = this._node(referenceObject);
685685
const prevNode = this._node(referenceNode.previousSibling);
686686
const newNode = this._node(newObject);
@@ -718,12 +718,12 @@ class SymbolTree {
718718
*
719719
* @method insertAfter
720720
* @memberOf module:symbol-tree#
721-
* @param {Object} newObject
722721
* @param {Object} referenceObject
722+
* @param {Object} newObject
723723
* @throws {Error} If the newObject is already present in this SymbolTree
724724
* @return {Object} newObject
725725
*/
726-
insertAfter(newObject, referenceObject) {
726+
insertAfter(referenceObject, newObject) {
727727
const referenceNode = this._node(referenceObject);
728728
const nextNode = this._node(referenceNode.nextSibling);
729729
const newNode = this._node(newObject);
@@ -761,12 +761,12 @@ class SymbolTree {
761761
*
762762
* @method prependChild
763763
* @memberOf module:symbol-tree#
764-
* @param {Object} newObject
765764
* @param {Object} referenceObject
765+
* @param {Object} newObject
766766
* @throws {Error} If the newObject is already present in this SymbolTree
767767
* @return {Object} newObject
768768
*/
769-
prependChild(newObject, referenceObject) {
769+
prependChild(referenceObject, newObject) {
770770
const referenceNode = this._node(referenceObject);
771771
const newNode = this._node(newObject);
772772

@@ -775,7 +775,7 @@ class SymbolTree {
775775
}
776776

777777
if (referenceNode.hasChildren) {
778-
this.insertBefore(newObject, referenceNode.firstChild);
778+
this.insertBefore(referenceNode.firstChild, newObject);
779779
}
780780
else {
781781
newNode.parent = referenceObject;
@@ -795,12 +795,12 @@ class SymbolTree {
795795
*
796796
* @method appendChild
797797
* @memberOf module:symbol-tree#
798-
* @param {Object} newObject
799798
* @param {Object} referenceObject
799+
* @param {Object} newObject
800800
* @throws {Error} If the newObject is already present in this SymbolTree
801801
* @return {Object} newObject
802802
*/
803-
appendChild(newObject, referenceObject) {
803+
appendChild(referenceObject, newObject) {
804804
const referenceNode = this._node(referenceObject);
805805
const newNode = this._node(newObject);
806806

@@ -809,7 +809,7 @@ class SymbolTree {
809809
}
810810

811811
if (referenceNode.hasChildren) {
812-
this.insertAfter(newObject, referenceNode.lastChild);
812+
this.insertAfter(referenceNode.lastChild, newObject);
813813
}
814814
else {
815815
newNode.parent = referenceObject;

0 commit comments

Comments
 (0)