-
Notifications
You must be signed in to change notification settings - Fork 54
Open
Description
Upstream issue: pre-commit/pre-commit#3028.
Summary
Tried to add a file to git lfs and this broke the forbid-binary hook.
Description
bash:
git lfs track "*.pdf"
git add foo.pdf && git commit -m "chore: Test LFS"This now fails since the files are binary, even though they're stored as pointers:
Forbid binaries..........................................................Failed
- hook id: forbid-binary
- exit code: 1
Additional info
pre-commit --version
pre-commit 3.3.3.pre-commit-config.yaml:
- repo: https://github.com/jumanjihouse/pre-commit-hooks
rev: 3.0.0
hooks:
- id: forbid-binaryProposed solution(s)
Maybe there's an easy fix around this, potentially even looking at .gitattributes?
Person-93
Metadata
Metadata
Assignees
Labels
No labels