activate unused rewrite checks failOnDryRunResults

Vincent Potucek · Vincent Potucek · commit 035df981d2e2 · 2025-07-01T19:13:11.000+02:00
diff --git a/gradle/plugins/common/src/main/kotlin/junitbuild.java-library-conventions.gradle.kts b/gradle/plugins/common/src/main/kotlin/junitbuild.java-library-conventions.gradle.kts
@@ -18,11 +18,17 @@ plugins {
 
 rewrite {
 	activeRecipe("org.openrewrite.java.migrate.UpgradeToJava17")
+	activeRecipe("org.openrewrite.staticanalysis.RemoveUnusedPrivateMethods")
+	activeRecipe("org.openrewrite.staticanalysis.MissingOverrideAnnotation")
+	failOnDryRunResults = true
 }
 
 dependencies {
-	rewrite(platform("org.openrewrite.recipe:rewrite-recipe-bom:latest.release"))
+	// https://github.com/openrewrite/rewrite/issues/5677
+	// rewrite(platform("org.openrewrite.recipe:rewrite-recipe-bom:latest.release"))
+	rewrite(platform("org.openrewrite.recipe:rewrite-recipe-bom:3.10.0"))
 	rewrite("org.openrewrite.recipe:rewrite-migrate-java")
+	rewrite("org.openrewrite.recipe:rewrite-static-analysis")
 }
 
 val mavenizedProjects: List<Project> by rootProject.extra
@@ -280,6 +286,9 @@ tasks {
 	checkstyleTest {
 		config = resources.text.fromFile(checkstyle.configDirectory.file("checkstyleTest.xml"))
 	}
+	check {
+		dependsOn("rewriteDryRun")
+	}
 }
 
 pluginManager.withPlugin("java-test-fixtures") {

Original file line number	Diff line number	Diff line change
`@@ -18,11 +18,17 @@ plugins {`
`18`	`18`
`19`	`19`	`rewrite {`
`20`	`20`	`activeRecipe("org.openrewrite.java.migrate.UpgradeToJava17")`
	`21`	`+ activeRecipe("org.openrewrite.staticanalysis.RemoveUnusedPrivateMethods")`
	`22`	`+ activeRecipe("org.openrewrite.staticanalysis.MissingOverrideAnnotation")`
	`23`	`+ failOnDryRunResults = true`
`21`	`24`	`}`
`22`	`25`
`23`	`26`	`dependencies {`
`24`		`- rewrite(platform("org.openrewrite.recipe:rewrite-recipe-bom:latest.release"))`
	`27`	`+ // https://github.com/openrewrite/rewrite/issues/5677`
	`28`	`+ // rewrite(platform("org.openrewrite.recipe:rewrite-recipe-bom:latest.release"))`
	`29`	`+ rewrite(platform("org.openrewrite.recipe:rewrite-recipe-bom:3.10.0"))`
`25`	`30`	`rewrite("org.openrewrite.recipe:rewrite-migrate-java")`
	`31`	`+ rewrite("org.openrewrite.recipe:rewrite-static-analysis")`
`26`	`32`	`}`
`27`	`33`
`28`	`34`	`val mavenizedProjects: List<Project> by rootProject.extra`
`@@ -280,6 +286,9 @@ tasks {`
`280`	`286`	`checkstyleTest {`
`281`	`287`	`config = resources.text.fromFile(checkstyle.configDirectory.file("checkstyleTest.xml"))`
`282`	`288`	`}`
	`289`	`+ check {`
	`290`	`+ dependsOn("rewriteDryRun")`
	`291`	`+ }`
`283`	`292`	`}`
`284`	`293`
`285`	`294`	`pluginManager.withPlugin("java-test-fixtures") {`