[Possible issue] deprecated expectAssertionFailedError ?

[sepxxx]

Hi! I’d like to refactor AssertArrayEqualsAssertionsTests assertArrayEqualsBooleanArrayVsNull and other tests to use assertThrows().
Is this acceptable? I can submit a PR if yes.

[sbrannen]

expectAssertionFailedError() resides in AssertionTestUtils which is an internal "test fixture" that we use to test our own assertion support without relying on our own assertion support or a third-party library. In other words we don't want to test our assertion support with itself, and we don't necessarily want to rely on a third-party assertion library to test our own assertion library.

If I recall correctly, we've done that ever since the pre-alpha development phase for JUnit 5.

What makes you think that expectAssertionFailedError() is deprecated?

In any case, I don't personally see any compelling reason to rewrite those tests to use AssertJ.

If we did choose to do that, we would probably want to remove all usage of AssertionTestUtils.