Skip to content

Add withPosition(FilePosition) method to FileSource #4629

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Sep 13, 2025
Merged

Add withPosition(FilePosition) method to FileSource #4629

merged 5 commits into from
Sep 13, 2025
+55 −0

Conversation

lslonina
Copy link
Contributor

@lslonina lslonina commented Jun 6, 2025 •
edited by marcphilipp
Loading

  • Refactor creation to avoid redundant canonicalization calls
  • Introduced internal factory methods for clearer construction paths

Overview

I hereby agree to the terms of the JUnit Contributor License Agreement.

Definition of Done

mpkorstanje

This comment was marked as duplicate.

Sign in to view

@mpkorstanje

This comment was marked as outdated.

Sign in to view
@ALUMINIS650

This comment was marked as outdated.

Sign in to view
@lslonina
Copy link
Contributor Author

lslonina commented Jun 6, 2025

@mpkorstanje Thanks for the feedback — the code can definitely be simplified, especially with the instance method approach. Let’s see how the discussion on this topic evolves; I’ll keep this marked as a draft for now.

@lslonina lslonina marked this pull request as draft June 6, 2025 10:46
@marcphilipp marcphilipp linked an issue Jun 6, 2025 that may be closed by this pull request
Introduce withPosition() "wither" method in FileSource #4630
Closed
@lslonina lslonina force-pushed the file_source_reuse branch from 130f158 to bf8423e Compare June 10, 2025 20:07
@mpkorstanje mpkorstanje mentioned this pull request Sep 8, 2025
Closed
@mpkorstanje
Copy link
Contributor

@mpkorstanje Thanks for the feedback — the code can definitely be simplified, especially with the instance method approach. Let’s see how the discussion on this topic evolves; I’ll keep this marked as a draft for now.

@lslonina the issue has moved off team discussion. Do you have time available to patch up your PR or would you prefer to hand it over?

@lslonina lslonina marked this pull request as ready for review September 11, 2025 19:47
@lslonina
Copy link
Contributor Author

Thanks for picking this up. I’ve added @API(status = EXPERIMENTAL, since = "6.0"), but if this is a backport candidate, should we change it to since = "5.13.5" instead?

@marcphilipp
Copy link
Member

Thanks for picking this up. I’ve added @API(status = EXPERIMENTAL, since = "6.0"), but if this is a backport candidate, should we change it to since = "5.13.5" instead?

Good question! Please keep using 6.0. We'll adjust it when backporting.

@marcphilipp

This comment was marked as outdated.

Sign in to view
@marcphilipp marcphilipp changed the title Add withPosition() factory method to FileSource Add withPosition(FilePosition) method to FileSource Sep 13, 2025
@marcphilipp marcphilipp self-assigned this Sep 13, 2025
@marcphilipp marcphilipp merged commit 64836f5 into junit-team:main Sep 13, 2025
21 checks passed
@marcphilipp
Copy link
Member

Thanks, @lslonina! 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marcphilipp marcphilipp marcphilipp approved these changes

+2 more reviewers

@vlsi vlsi vlsi left review comments

@mpkorstanje mpkorstanje mpkorstanje left review comments

Reviewers whose approvals may not affect merge requirements
Assignees

@marcphilipp marcphilipp

Labels
component: Platform status: backported theme: discovery type: enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Introduce withPosition() "wither" method in FileSource
5 participants
@lslonina @mpkorstanje @ALUMINIS650 @marcphilipp @vlsi