Skip to content

Enable Checkstyle rules to increase consistency #4748

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Jul 10, 2025
Merged

Enable Checkstyle rules to increase consistency #4748

merged 6 commits into from
Jul 10, 2025

Conversation

@marcphilipp
Copy link
Member

@marcphilipp marcphilipp commented Jul 10, 2025 •
edited
Loading

  • Use text blocks and String.formatted and forbid String.format
  • Hide utility class constructors
  • Order modifiers canonically
  • Avoid potential NPEs for String.equals() calls
  • Declare serialVersionUID explicitly
  • Remove empty statement

I hereby agree to the terms of the JUnit Contributor License Agreement.

Definition of Done

@marcphilipp marcphilipp self-assigned this Jul 10, 2025
@marcphilipp marcphilipp changed the base branch from main to marc/error-prone-checks July 10, 2025 09:54
marcphilipp added a commit that referenced this pull request Jul 10, 2025
@marcphilipp
Remove OpenRewrite from build
cfd5845 
We used OpenRewrite as a migration aid when bumping the Java baseline
from 8 to 17. After evaluating its use for ongoing static analysis, it
doesn't provide enough added value to justify maintaining configuration
etc. for another tool. In #4748, additional Checkstyle rules will be
enabled instead which address almost all issues found by OpenRewrite's
recipes. Moreover, openrewrite/rewrite-gradle-plugin#212 prevents us
from using it in our build.
@marcphilipp marcphilipp mentioned this pull request Jul 10, 2025
Closed
6 tasks
Base automatically changed from marc/error-prone-checks to main July 10, 2025 10:16
@marcphilipp marcphilipp force-pushed the marc/stricter-checkstyle branch from 734e7dc to 56309fb Compare July 10, 2025 10:25
@marcphilipp marcphilipp marked this pull request as ready for review July 10, 2025 10:25
@marcphilipp marcphilipp added this to the 6.0.0-M2 milestone Jul 10, 2025
@Pankraz76
Copy link
Contributor

Pankraz76 commented Jul 10, 2025

nice to see this, thanks for the increment.

@marcphilipp marcphilipp merged commit a3d2a2b into main Jul 10, 2025
14 checks passed
@marcphilipp marcphilipp deleted the marc/stricter-checkstyle branch July 10, 2025 10:39
This was referenced Jul 11, 2025
Closed
Merged
@Pankraz76
Copy link
Contributor

Pankraz76 commented Jul 11, 2025 •
edited
Loading

seems incomplete as redone.

@Pankraz76 Pankraz76 mentioned this pull request Aug 28, 2025
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sormuras sormuras sormuras approved these changes

Assignees

@marcphilipp marcphilipp

Labels

component: Jupiter component: Platform component: Vintage type: enhancement

Projects

None yet

Milestone

6.0.0-M2

Development

Successfully merging this pull request may close these issues.

4 participants

@marcphilipp @Pankraz76 @sormuras