Skip to content

Commit 07dba0f

Browse files
authored
Adds success message on "run job from definition" (#301)
1 parent ad785dd commit 07dba0f

File tree

2 files changed

+9
-2
lines changed

2 files changed

+9
-2
lines changed

src/mainviews/create-job-from-definition.tsx

Lines changed: 8 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,9 @@ export interface ICreateJobFromDefinitionProps {
1818
model: ICreateJobModel;
1919
handleModelChange: (model: ICreateJobModel) => void;
2020
showListView: (
21-
list: JobsView.ListJobs | JobsView.ListJobDefinitions
21+
list: JobsView.ListJobs | JobsView.ListJobDefinitions,
22+
newlyCreatedId?: string,
23+
newlyCreatedName?: string
2224
) => unknown;
2325
// Extension point: optional additional component
2426
advancedOptions: React.FunctionComponent<SchedulerTokens.IAdvancedOptionsProps>;
@@ -138,7 +140,11 @@ export function CreateJobFromDefinition(
138140
)
139141
.then(response => {
140142
// Switch to the list view with "Job List" active
141-
props.showListView(JobsView.ListJobs);
143+
props.showListView(
144+
JobsView.ListJobs,
145+
response.job_id,
146+
props.model.jobName
147+
);
142148
})
143149
.catch((error: Error) => {
144150
props.handleModelChange({

src/mainviews/detail-view/job-definition.tsx

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -67,6 +67,7 @@ export function JobDefinition(props: IJobDefinitionProps): JSX.Element {
6767
const runJobDefinition = () => {
6868
const initialState: ICreateJobModel = {
6969
...emptyCreateJobModel(),
70+
jobName: props.model.name,
7071
inputFile: props.model.inputFile,
7172
outputPath: props.model.outputPrefix ?? '',
7273
environment: props.model.environment,

0 commit comments

Comments
 (0)