Prevent overriding server_settings on base provider class (#825)

Author: krassowski

packages/jupyter-ai-magics/jupyter_ai_magics/providers.py

@@ -196,6 +196,18 @@ def __new__(mcs, name, bases, namespace, **kwargs):
 
         return cls
 
+    @property
+    def server_settings(cls):
+        return cls._server_settings
+
+    @server_settings.setter
+    def server_settings(cls, value):
+        if cls._server_settings is not None:
+            raise AttributeError("'server_settings' attribute was already set")
+        cls._server_settings = value
+
+    _server_settings = None
+
 
 class BaseProvider(BaseModel, metaclass=ProviderMetaclass):
     #

packages/jupyter-ai-magics/jupyter_ai_magics/tests/test_provider_metaclass.py

@@ -1,8 +1,10 @@
+from types import MappingProxyType
 from typing import ClassVar, Optional
 
 from langchain.pydantic_v1 import BaseModel
+from pytest import raises
 
-from ..providers import ProviderMetaclass
+from ..providers import BaseProvider, ProviderMetaclass
 
 
 def test_provider_metaclass():
@@ -24,3 +26,10 @@ class Child(Base, Parent, metaclass=ProviderMetaclass):
         test: ClassVar[str] = "expected"
 
     assert Child.test == "expected"
+
+
+def test_base_provider_server_settings_read_only():
+    BaseProvider.server_settings = MappingProxyType({})
+
+    with raises(AttributeError, match="'server_settings' attribute was already set"):
+        BaseProvider.server_settings = MappingProxyType({})