Fixed most of lint warnings

Author: kbiakov

codeview/src/main/AndroidManifest.xml

@@ -2,7 +2,6 @@
           xmlns:android="http://schemas.android.com/apk/res/android">
 
     <application
-        android:allowBackup="true"
         android:label="@string/app_name"
         android:supportsRtl="true">
 

codeview/src/main/java/io/github/kbiakov/codeview/highlight/CodeHighlighter.kt

@@ -32,10 +32,10 @@ object CodeHighlighter {
     // - Helpers
 
     /**
-     * Parse user input by extracting highlighted content.
+     * Parse input by extracting highlighted content.
      *
      * @param result Syntax unit
-     * @return Parsed content to highlight
+     * @return Content to highlight
      */
     private infix fun String.highlight(result: ParseResult) = safeLT {
         substring(result.offset, result.offset + result.length)

codeview/src/main/java/io/github/kbiakov/codeview/views/LineDiffView.kt

@@ -15,15 +15,12 @@ import io.github.kbiakov.codeview.highlight.FontCache
  *
  * @author Kirill Biakov
  */
-class LineDiffView : RelativeLayout {
+class LineDiffView(context: Context) : RelativeLayout(context) {
 
     private val tvLineDiff: TextView
     private val tvLineContent: TextView
 
-    /**
-     * Default constructor.
-     */
-    constructor(context: Context) : super(context) {
+    init {
         val inflater = context.getSystemService(Context.LAYOUT_INFLATER_SERVICE) as LayoutInflater
         inflater.inflate(R.layout.item_code_diff, this, true)
 
@@ -39,19 +36,16 @@ class LineDiffView : RelativeLayout {
          * @param model Diff model
          * @return Created line diff view
          */
-        fun create(context: Context, model: DiffModel): LineDiffView {
-            val diffView = LineDiffView(context)
-            diffView.tvLineDiff.text = if (model.isAddition) "+" else "-"
-            diffView.tvLineContent.text = model.content
-            diffView.tvLineContent.typeface = FontCache.get(context).getTypeface(context)
+        fun create(context: Context, model: DiffModel) = LineDiffView(context).apply {
+            tvLineDiff.text = if (model.isAddition) "+" else "-"
+            tvLineContent.text = model.content
+            tvLineContent.typeface = FontCache.get(context).getTypeface(context)
 
-            diffView.setBackgroundColor(ContextCompat.getColor(context,
+            setBackgroundColor(ContextCompat.getColor(context,
                     if (model.isAddition)
                         R.color.diff_add_background
                     else
                         R.color.diff_del_background))
-
-            return diffView
         }
     }
 }

codeview/src/main/res/layout/item_code_diff.xml

@@ -9,20 +9,19 @@
         android:layout_width="@dimen/line_num_width"
         android:layout_height="@dimen/line_height"
         android:gravity="center"
-        android:fontFamily="monospace"
         android:textSize="@dimen/line_text_size"
         android:text="@string/stub_line_num"/>
 
     <TextView
         android:id="@+id/tv_line_content"
         android:layout_width="wrap_content"
         android:layout_height="@dimen/line_height"
-        android:layout_marginLeft="16dp"
-        android:layout_marginRight="16dp"
+        android:layout_marginLeft="@dimen/default_margin"
+        android:layout_marginRight="@dimen/default_margin"
+        android:layout_toEndOf="@+id/tv_line_diff"
         android:layout_toRightOf="@+id/tv_line_diff"
         android:gravity="center_vertical"
-        android:fontFamily="monospace"
-        android:singleLine="true"
+        android:maxLines="1"
         android:textSize="@dimen/line_text_size"
         android:text="@string/stub_line_content"/>
 

codeview/src/main/res/layout/item_code_line.xml

@@ -17,8 +17,9 @@
         android:id="@+id/tv_line_content"
         android:layout_width="wrap_content"
         android:layout_height="match_parent"
-        android:layout_marginLeft="16dp"
-        android:layout_marginRight="16dp"
+        android:layout_marginLeft="@dimen/default_margin"
+        android:layout_marginRight="@dimen/default_margin"
+        android:layout_toEndOf="@+id/tv_line_num"
         android:layout_toRightOf="@+id/tv_line_num"
         android:gravity="center_vertical"
         android:maxLines="1"

codeview/src/main/res/layout/layout_code_view.xml

@@ -23,6 +23,7 @@
         android:id="@+id/shadow_right_border"
         android:layout_width="@dimen/shadow_width"
         android:layout_height="match_parent"
+        android:layout_alignParentEnd="true"
         android:layout_alignParentRight="true"/>
 
     <LinearLayout

codeview/src/main/res/values/colors.xml

@@ -1,11 +1,5 @@
 <?xml version="1.0" encoding="utf-8"?>
 <resources>
-    <color name="code_num">#99a8b7</color>
-    <color name="code_num_background">#f2f2f6</color>
-    <color name="code_content">#2c2d30</color>
-    <color name="code_content_background">#e9edf4</color>
-    <color name="note">#4c5d6e</color>
-
     <color name="diff_add_background">#EAFFEA</color>
     <color name="diff_del_background">#FFECEC</color>
 </resources>

codeview/src/main/res/values/dimens.xml

@@ -1,5 +1,6 @@
 <?xml version="1.0" encoding="utf-8"?>
 <resources>
+    <dimen name="default_margin">16dp</dimen>
     <dimen name="line_num_width">32dp</dimen>
     <dimen name="line_height">24dp</dimen>
     <dimen name="line_border_height">4dp</dimen>

example/src/main/AndroidManifest.xml

@@ -4,7 +4,6 @@
 
     <application
         android:name=".BaseApplication"
-        android:allowBackup="true"
         android:icon="@mipmap/ic_launcher"
         android:label="@string/app_name"
         android:supportsRtl="true"
@@ -19,4 +18,4 @@
 
     </application>
 
-</manifest>
+</manifest>