Skip to content

Commit 44cd4e7

Browse files
authored
Merge pull request #12 from CatalinAnt/bodda93-patch-2
Update README.md
2 parents c7cb85e + 2fed7e9 commit 44cd4e7

File tree

1 file changed

+78
-75
lines changed

1 file changed

+78
-75
lines changed

README.md

Lines changed: 78 additions & 75 deletions
Original file line numberDiff line numberDiff line change
@@ -57,38 +57,17 @@ Link to commit:(same as for the first one)
5757
Screenshot of branch measurement:
5858
![image](https://github.com/CatalinAnt/algorithms-SEP-95/assets/113595149/94eec9b6-3dd6-46e3-b087-40892eccc10e)
5959

60-
#### Abdullah Abdelkhalik
61-
6260

63-
pythagoras
64-
65-
https://github.com/CatalinAnt/algorithms-SEP-95/commit/5651abafebe8ae3a5ea63e74883bb991acf19303
6661

67-
![pythagoras_hits](https://github.com/CatalinAnt/algorithms-SEP-95/assets/114078193/0df1fa2b-2185-4b9f-ae65-5d969edb009b)
6862

6963

70-
first_unique_char
7164

72-
https://github.com/CatalinAnt/algorithms-SEP-95/commit/c16f26e952322b2c1729778a4141a57103ba7658
7365

74-
![first_unique_char_hits](https://github.com/CatalinAnt/algorithms-SEP-95/assets/114078193/10d7c45c-398e-4408-8f11-6771f51fa95c)
7566

7667

77-
#### Abdullah Abdelkhalik
7868

7969

80-
pythagoras
8170

82-
https://github.com/CatalinAnt/algorithms-SEP-95/commit/5651abafebe8ae3a5ea63e74883bb991acf19303
83-
84-
![pythagoras_hits](https://github.com/CatalinAnt/algorithms-SEP-95/assets/114078193/0df1fa2b-2185-4b9f-ae65-5d969edb009b)
85-
86-
87-
first_unique_char
88-
89-
https://github.com/CatalinAnt/algorithms-SEP-95/commit/c16f26e952322b2c1729778a4141a57103ba7658
90-
91-
![first_unique_char_hits](https://github.com/CatalinAnt/algorithms-SEP-95/assets/114078193/10d7c45c-398e-4408-8f11-6771f51fa95c)
9271

9372

9473
#### Almuthana Almustafa
@@ -144,40 +123,6 @@ Link to commit:(same as for the first one)
144123
Screenshot of branch measurement:
145124
![image](https://github.com/CatalinAnt/algorithms-SEP-95/assets/113595149/94eec9b6-3dd6-46e3-b087-40892eccc10e)
146125

147-
#### Abdullah Abdelkhalik
148-
149-
150-
pythagoras
151-
152-
https://github.com/CatalinAnt/algorithms-SEP-95/commit/5651abafebe8ae3a5ea63e74883bb991acf19303
153-
154-
![pythagoras_hits](https://github.com/CatalinAnt/algorithms-SEP-95/assets/114078193/0df1fa2b-2185-4b9f-ae65-5d969edb009b)
155-
156-
157-
first_unique_char
158-
159-
https://github.com/CatalinAnt/algorithms-SEP-95/commit/c16f26e952322b2c1729778a4141a57103ba7658
160-
161-
![first_unique_char_hits](https://github.com/CatalinAnt/algorithms-SEP-95/assets/114078193/10d7c45c-398e-4408-8f11-6771f51fa95c)
162-
163-
164-
#### Abdullah Abdelkhalik
165-
166-
167-
pythagoras
168-
169-
https://github.com/CatalinAnt/algorithms-SEP-95/commit/5651abafebe8ae3a5ea63e74883bb991acf19303
170-
171-
![pythagoras_hits](https://github.com/CatalinAnt/algorithms-SEP-95/assets/114078193/0df1fa2b-2185-4b9f-ae65-5d969edb009b)
172-
173-
174-
first_unique_char
175-
176-
https://github.com/CatalinAnt/algorithms-SEP-95/commit/c16f26e952322b2c1729778a4141a57103ba7658
177-
178-
![first_unique_char_hits](https://github.com/CatalinAnt/algorithms-SEP-95/assets/114078193/10d7c45c-398e-4408-8f11-6771f51fa95c)
179-
180-
181126

182127
## Coverage improvement
183128

@@ -283,27 +228,7 @@ New coverage:
283228
For rotate_image, thre was a 33% coverage improvement with the existing tool and 25% with manual tool.
284229

285230

286-
## Abdullah Abdelkhalik
287-
288-
test_maths
289-
290-
https://github.com/CatalinAnt/algorithms-SEP-95/commit/60832d9c672efd586848077cc41a52630d34371b
291231

292-
![pythagoras_before](https://github.com/CatalinAnt/algorithms-SEP-95/assets/114078193/cf57112b-1aef-4a10-a41f-bd4b797e2012)
293-
294-
![pythagoras_after](https://github.com/CatalinAnt/algorithms-SEP-95/assets/114078193/1aa45c17-46fc-49d3-944a-03c2276d1be6)
295-
296-
the coverage is improved by 28%, the code only hit one of the five branches and cover only one of the three cases of the pythagoras theory. I added the other two cases, i could have a fourth case where none of the cases is present.
297-
298-
test_strings
299-
300-
https://github.com/CatalinAnt/algorithms-SEP-95/commit/5651abafebe8ae3a5ea63e74883bb991acf19303
301-
302-
![first_unique_char_before](https://github.com/CatalinAnt/algorithms-SEP-95/assets/114078193/9910ec69-73b0-4c87-afc8-abc01f65a423)
303-
304-
![first_unique_char_after](https://github.com/CatalinAnt/algorithms-SEP-95/assets/114078193/10859fac-776c-4a48-8a1c-9531afcbfa9b)
305-
306-
The coverage is improved by 13%, the code only hit three out of five branches and only set up two examples. I added a case where there is no unique letter.
307232

308233
## Almuthana Almustafa
309234

@@ -338,6 +263,84 @@ existing tool result after:
338263

339264
The coverage improved by 86% due to the creation of new tests.
340265

266+
267+
268+
269+
270+
271+
272+
273+
274+
275+
276+
277+
278+
279+
280+
281+
282+
283+
284+
285+
286+
287+
288+
289+
#### Abdullah Abdelkhalik
290+
291+
292+
pythagoras
293+
294+
https://github.com/CatalinAnt/algorithms-SEP-95/commit/5651abafebe8ae3a5ea63e74883bb991acf19303
295+
296+
![pythagoras_hits](https://github.com/CatalinAnt/algorithms-SEP-95/assets/114078193/4c90fc73-980b-4617-b1ec-01041bbb1a06)
297+
298+
299+
300+
first_unique_char
301+
302+
https://github.com/CatalinAnt/algorithms-SEP-95/commit/c16f26e952322b2c1729778a4141a57103ba7658
303+
304+
![first_unique_char_hits](https://github.com/CatalinAnt/algorithms-SEP-95/assets/114078193/10d7c45c-398e-4408-8f11-6771f51fa95c)
305+
306+
307+
308+
309+
310+
## Improvements
311+
312+
test_maths
313+
314+
https://github.com/CatalinAnt/algorithms-SEP-95/commit/60832d9c672efd586848077cc41a52630d34371b
315+
316+
![pythagoras_before](https://github.com/CatalinAnt/algorithms-SEP-95/assets/114078193/cf57112b-1aef-4a10-a41f-bd4b797e2012)
317+
318+
![pythagoras_after](https://github.com/CatalinAnt/algorithms-SEP-95/assets/114078193/1aa45c17-46fc-49d3-944a-03c2276d1be6)
319+
320+
the coverage is improved by 28%, the code only hit one of the five branches and cover only one of the three cases of the pythagoras theory. I added the other two cases, i could have a fourth case where none of the cases is present.
321+
322+
test_strings
323+
324+
https://github.com/CatalinAnt/algorithms-SEP-95/commit/5651abafebe8ae3a5ea63e74883bb991acf19303
325+
326+
![first_unique_char_before](https://github.com/CatalinAnt/algorithms-SEP-95/assets/114078193/9910ec69-73b0-4c87-afc8-abc01f65a423)
327+
328+
![first_unique_char_after](https://github.com/CatalinAnt/algorithms-SEP-95/assets/114078193/10859fac-776c-4a48-8a1c-9531afcbfa9b)
329+
330+
The coverage is improved by 13%, the code only hit three out of five branches and only set up two examples. I added a case where there is no unique letter.
331+
332+
333+
334+
335+
336+
337+
338+
339+
340+
341+
342+
343+
341344
### Overall
342345

343346
<Provide a screenshot of the old coverage results by running an existing tool (the same as you already showed above)>

0 commit comments

Comments
 (0)