review: remove dead code

Author: archandatta

server/lib/cdpmonitor/cdp_proto.go

@@ -263,16 +263,6 @@ type cdpTargetAttachedToTargetParams struct {
 	WaitingForDebugger bool                `json:"waitingForDebugger"`
 }
 
-// cdpTargetTargetCreatedParams mirrors Target.targetCreated params.
-type cdpTargetTargetCreatedParams struct {
-	TargetInfo cdpTargetTargetInfo `json:"targetInfo"`
-}
-
-// cdpTargetTargetDestroyedParams mirrors Target.targetDestroyed params.
-type cdpTargetTargetDestroyedParams struct {
-	TargetID string `json:"targetId"`
-}
-
 // cdpTargetDetachedFromTargetParams mirrors Target.detachedFromTarget params.
 type cdpTargetDetachedFromTargetParams struct {
 	SessionID string `json:"sessionId"`

server/lib/cdpmonitor/cdp_proto_test.go

@@ -37,8 +37,6 @@ func TestLayer1Roundtrip(t *testing.T) {
 		{"Page.loadEventFired", "Page_loadEventFired.json", func() any { return new(cdpPageLoadEventFiredParams) }},
 		{"PerformanceTimeline.timelineEventAdded", "PerformanceTimeline_timelineEventAdded.json", func() any { return new(cdpPerformanceTimelineEventAddedParams) }},
 		{"Target.attachedToTarget", "Target_attachedToTarget.json", func() any { return new(cdpTargetAttachedToTargetParams) }},
-		{"Target.targetCreated", "Target_targetCreated.json", func() any { return new(cdpTargetTargetCreatedParams) }},
-		{"Target.targetDestroyed", "Target_targetDestroyed.json", func() any { return new(cdpTargetTargetDestroyedParams) }},
 		{"Target.detachedFromTarget", "Target_detachedFromTarget.json", func() any { return new(cdpTargetDetachedFromTargetParams) }},
 	}
 

server/lib/cdpmonitor/handlers.go

@@ -107,16 +107,6 @@ func (m *Monitor) dispatchEvent(msg cdpMessage) {
 		if m.decodeParams(msg.Method, msg.Params, &p) {
 			m.handleAttachedToTarget(p)
 		}
-	case "Target.targetCreated":
-		var p cdpTargetTargetCreatedParams
-		if m.decodeParams(msg.Method, msg.Params, &p) {
-			m.handleTargetCreated(p, msg.SessionID)
-		}
-	case "Target.targetDestroyed":
-		var p cdpTargetTargetDestroyedParams
-		if m.decodeParams(msg.Method, msg.Params, &p) {
-			m.handleTargetDestroyed(p, msg.SessionID)
-		}
 	case "Target.detachedFromTarget":
 		var p cdpTargetDetachedFromTargetParams
 		if m.decodeParams(msg.Method, msg.Params, &p) {
@@ -434,22 +424,6 @@ func (m *Monitor) handleAttachedToTarget(p cdpTargetAttachedToTargetParams) {
 	})
 }
 
-func (m *Monitor) handleTargetCreated(p cdpTargetTargetCreatedParams, sessionID string) {
-	data, _ := json.Marshal(map[string]any{
-		"target_id":   p.TargetInfo.TargetID,
-		"target_type": p.TargetInfo.Type,
-		"url":         p.TargetInfo.URL,
-	})
-	m.publishEvent(EventTargetCreated, events.CategoryPage, events.Source{Kind: events.KindCDP}, "Target.targetCreated", data, sessionID)
-}
-
-func (m *Monitor) handleTargetDestroyed(p cdpTargetTargetDestroyedParams, sessionID string) {
-	data, _ := json.Marshal(map[string]any{
-		"target_id": p.TargetID,
-	})
-	m.publishEvent(EventTargetDestroyed, events.CategoryPage, events.Source{Kind: events.KindCDP}, "Target.targetDestroyed", data, sessionID)
-}
-
 func (m *Monitor) handleDetachedFromTarget(p cdpTargetDetachedFromTargetParams) {
 	if p.SessionID == "" {
 		return

server/lib/cdpmonitor/handlers_test.go

@@ -235,33 +235,6 @@ func TestPageEvents(t *testing.T) {
 	assert.Equal(t, events.CategoryPage, ev3.Category)
 }
 
-func TestTargetEvents(t *testing.T) {
-	srv := newTestServer(t)
-	defer srv.close()
-
-	_, ec, cleanup := startMonitor(t, srv, nil)
-	defer cleanup()
-
-	srv.sendToMonitor(t, map[string]any{
-		"method": "Target.targetCreated",
-		"params": map[string]any{
-			"targetInfo": map[string]any{"targetId": "t-1", "type": "page", "url": "https://new.example.com"},
-		},
-	})
-	ev := ec.waitFor(t, "target_created", 2*time.Second)
-	assert.Equal(t, events.CategoryPage, ev.Category)
-	var data map[string]any
-	require.NoError(t, json.Unmarshal(ev.Data, &data))
-	assert.Equal(t, "t-1", data["target_id"])
-
-	srv.sendToMonitor(t, map[string]any{
-		"method": "Target.targetDestroyed",
-		"params": map[string]any{"targetId": "t-1"},
-	})
-	ev2 := ec.waitFor(t, "target_destroyed", 2*time.Second)
-	assert.Equal(t, events.CategoryPage, ev2.Category)
-}
-
 func TestBindingAndTimeline(t *testing.T) {
 	srv := newTestServer(t)
 	defer srv.close()

server/lib/cdpmonitor/monitor.go

@@ -423,20 +423,10 @@ func (m *Monitor) attachExistingTargets(ctx context.Context) {
 		}
 		targetID := ti.TargetID
 		m.asyncWg.Go(func() {
-			res, err := m.send(ctx, "Target.attachToTarget", map[string]any{
+			_, _ = m.send(ctx, "Target.attachToTarget", map[string]any{
 				"targetId": targetID,
 				"flatten":  true,
 			}, "")
-			if err != nil {
-				return
-			}
-			var attachResp struct {
-				SessionID string `json:"sessionId"`
-			}
-			if json.Unmarshal(res, &attachResp) == nil && attachResp.SessionID != "" {
-				m.enableDomains(ctx, attachResp.SessionID, targetTypePage)
-				_ = m.injectScript(ctx, attachResp.SessionID)
-			}
 		})
 	}
 }

server/lib/cdpmonitor/testdata/Target_targetCreated.json

@@ -25,8 +25,6 @@ const (
 	EventDOMContentLoaded     = "dom_content_loaded"      // Page.domContentEventFired
 	EventPageLoad             = "page_load"               // Page.loadEventFired
 	EventLayoutShift          = "layout_shift"            // PerformanceTimeline event of type "layout-shift"
-	EventTargetCreated        = "target_created"          // Target.targetCreated
-	EventTargetDestroyed      = "target_destroyed"        // Target.targetDestroyed
 )
 
 // Computed events — synthetic events derived by computed.go state machines.