improve random selection

Thanks for your help minortom!

Author: kernicPanel

README.md

@@ -9,10 +9,6 @@ Bitwig browser random selection
 
 This WILL lead to unexpected results, be sure to lower your volume before using.
 
-## SECOND WARNING
-
-I don't know Java, and it's my first Bitwig extension, so I can guarantee that this code is awful.
-
 ## Motivation
 
 I enjoy surprises, and I think that creativity comes from constraints.

src/main/java/com/kernicpanel/browserRandomizerExtension.java

@@ -5,8 +5,6 @@
 import com.bitwig.extension.controller.ControllerExtension;
 
 import java.util.Random;
-import java.util.concurrent.atomic.AtomicReference;
-import java.util.stream.IntStream;
 
 public class browserRandomizerExtension extends ControllerExtension {
   protected browserRandomizerExtension(
@@ -22,73 +20,42 @@ public void init() {
     final PopupBrowser popupBrowser = host.createPopupBrowser();
     popupBrowser.exists().markInterested();
     final CursorTrack cursorTrack = host.createCursorTrack(0, 0);
-
-    AtomicReference<Integer> numberOfChoices = new AtomicReference<>(0);
-    AtomicReference<Integer> nextChoice = new AtomicReference<>(0);
     Random rand = new Random();
-    popupBrowser
-        .resultsColumn()
-        .entryCount()
-        .addValueObserver(
-            newValue -> {
-              if (newValue > 0) {
-                numberOfChoices.set(newValue);
-              }
-            });
+
+    popupBrowser.resultsColumn().entryCount().markInterested();
+    BrowserResultsItemBank resultsItemBank = popupBrowser.resultsColumn().createItemBank(100000);
 
     documentState
         .getSignalSetting("Select", "browser", "Select random item")
         .addSignalObserver(
-            selectRandomItem(
-                host, popupBrowser, cursorTrack, numberOfChoices, nextChoice, rand, false));
+            selectRandomItem(host, popupBrowser, cursorTrack, resultsItemBank, rand, false));
     documentState
         .getSignalSetting("Add", "browser", "Add current item")
         .addSignalObserver(popupBrowser::commit);
     documentState
         .getSignalSetting("Random", "browser", "Surprise me!")
         .addSignalObserver(
-            selectRandomItem(
-                host, popupBrowser, cursorTrack, numberOfChoices, nextChoice, rand, true));
+            selectRandomItem(host, popupBrowser, cursorTrack, resultsItemBank, rand, true));
   }
 
   private NoArgsCallback selectRandomItem(
       ControllerHost host,
       PopupBrowser popupBrowser,
       CursorTrack cursorTrack,
-      AtomicReference<Integer> numberOfChoices,
-      AtomicReference<Integer> nextChoice,
+      BrowserResultsItemBank resultsItemBank,
       Random rand,
       Boolean commit) {
     return () -> {
       if (!popupBrowser.exists().getAsBoolean()) {
         cursorTrack.endOfDeviceChainInsertionPoint().browse();
       }
-      // go back to first item
-      // unfortunately, selecting the first item does not work
-      // popupBrowser.selectFirstFile();
-      // TODO: replace this ugly trick with a proper way to select the first item
-      IntStream.range(0, numberOfChoices.get())
-          .forEach(
-              i -> {
-                host.println("up " + i);
-                popupBrowser.selectPreviousFile();
-              });
-
-      // go to next random choice
-      // once again, I did not find a proper way to select a specific item
-      if (numberOfChoices.get() > 0) {
-        nextChoice.set(rand.nextInt(numberOfChoices.get()));
-        host.println("nextChoice " + nextChoice.get());
-        IntStream.range(0, nextChoice.get())
-            .forEach(
-                i -> {
-                  host.println("down " + i);
-                  popupBrowser.selectNextFile();
-                });
+      resultsItemBank
+          .getItemAt(rand.nextInt(popupBrowser.resultsColumn().entryCount().get()))
+          .isSelected()
+          .set(true);
 
-        if (commit) {
-          host.scheduleTask(popupBrowser::commit, 300);
-        }
+      if (commit) {
+        host.scheduleTask(popupBrowser::commit, 300);
       }
     };
   }