feat: remove undesirable deprecated rules

`no-return-await` is enabled by `eslint-config-airbnb-base`, but it is
no longer necessary nor desirable, as explained in
<https://eslint.org/docs/latest/rules/no-return-await>.  Remove it.

`prefer-reflect` was not enabled and is removed to avoid deprecation
warnings from eslint-find-rules.

`import/imports-first` was not enabled and is removed to avoid
deprecation warnings from eslint-find-rules.

Signed-off-by: Kevin Locke <[email protected]>

Author: kevinoid

common-legacy.js

@@ -49,6 +49,29 @@ const rulesStyle = require("./rules/style.js");
 const rulesUnicorn = require("./rules/unicorn.js");
 const rulesVariables = require("./rules/variables.js");
 
+const airbnbLegacyRules = rulesToReplacements(
+  {
+    // Note: Order from
+    // https://github.com/airbnb/javascript/blob/eslint-config-airbnb-v19.0.4/packages/eslint-config-airbnb-base/legacy.js
+    ...airbnbBestPractices.rules,
+    ...airbnbErrors.rules,
+    ...airbnbNode.rules,
+    ...airbnbStyle.rules,
+    ...airbnbVariables.rules,
+    ...airbnbLegacy.rules
+  },
+  {
+    "@stylistic/eslint-plugin": "@stylistic",
+    "eslint-plugin-n": "n"
+  }
+);
+// Remove rules for eslint-plugin-n which isn't used by legacy configs
+const airbnbRules = rulesRemovePlugin(airbnbLegacyRules, "n");
+// remove undesirable deprecated rules
+delete airbnbRules["no-return-await"];
+delete airbnbRules["prefer-reflect"];
+delete airbnbRules["import/imports-first"];
+
 // Customized stylistic default configuration
 // https://eslint.style/guide/config-presets#configuration-factory
 const stylisticConfig = stylisticCustomize({ "semi": true });
@@ -67,25 +90,7 @@ module.exports = [
   {
     "name": "eslint-config-airbnb-base/legacy",
     // Include just rules to avoid undesirable settings and need for FlatCompat
-    "rules": rulesRemovePlugin(
-      rulesToReplacements(
-        {
-          // Note: Order from
-          // https://github.com/airbnb/javascript/blob/eslint-config-airbnb-v19.0.4/packages/eslint-config-airbnb-base/legacy.js
-          ...airbnbBestPractices.rules,
-          ...airbnbErrors.rules,
-          ...airbnbNode.rules,
-          ...airbnbStyle.rules,
-          ...airbnbVariables.rules,
-          ...airbnbLegacy.rules
-        },
-        {
-          "@stylistic/eslint-plugin": "@stylistic",
-          "eslint-plugin-n": "n"
-        }
-      ),
-      "n"
-    )
+    "rules": airbnbRules
   },
 
   jsdocConfig,

common.js

@@ -62,6 +62,29 @@ const rulesStyle = require("./rules/style.js");
 const rulesUnicorn = require("./rules/unicorn.js");
 const rulesVariables = require("./rules/variables.js");
 
+const airbnbRules = rulesToReplacements(
+  {
+    // Note: Order from
+    // https://github.com/airbnb/javascript/blob/eslint-config-airbnb-v19.0.4/packages/eslint-config-airbnb-base/index.js
+    ...airbnbBestPractices.rules,
+    ...airbnbErrors.rules,
+    ...airbnbNode.rules,
+    ...airbnbStyle.rules,
+    ...airbnbVariables.rules,
+    ...airbnbEs6.rules,
+    ...airbnbImports.rules,
+    ...airbnbStrict.rules
+  },
+  {
+    "@stylistic/eslint-plugin": "@stylistic",
+    "eslint-plugin-n": "n"
+  }
+);
+// remove undesirable deprecated rules
+delete airbnbRules["no-return-await"];
+delete airbnbRules["prefer-reflect"];
+delete airbnbRules["import/imports-first"];
+
 // Customized stylistic default configuration
 // https://eslint.style/guide/config-presets#configuration-factory
 const stylisticConfig = stylisticCustomize({ "semi": true });
@@ -86,24 +109,7 @@ module.exports = [
   {
     "name": "eslint-config-airbnb-base",
     // Include just rules to avoid undesirable settings and need for FlatCompat
-    "rules": rulesToReplacements(
-      {
-        // Note: Order from
-        // https://github.com/airbnb/javascript/blob/eslint-config-airbnb-v19.0.4/packages/eslint-config-airbnb-base/index.js
-        ...airbnbBestPractices.rules,
-        ...airbnbErrors.rules,
-        ...airbnbNode.rules,
-        ...airbnbStyle.rules,
-        ...airbnbVariables.rules,
-        ...airbnbEs6.rules,
-        ...airbnbImports.rules,
-        ...airbnbStrict.rules
-      },
-      {
-        "@stylistic/eslint-plugin": "@stylistic",
-        "eslint-plugin-n": "n"
-      }
-    )
+    "rules": airbnbRules
   },
 
   jsdocConfig,