Fix review findings

kimkulling · web-flow · commit ae3adf86381b · 2025-02-18T09:49:15.000+01:00
diff --git a/code/Random/RandomGenerator.cpp b/code/Random/RandomGenerator.cpp
@@ -73,9 +73,9 @@ unsigned int mersenne_twister() {
     bool ok = true;
     if (static_cast<unsigned int>(idx) >= N) {
         if (static_cast<unsigned int>(idx) > N) {
-            ok |= mersenne_twister_vector_init(vector, N);
+            ok &= mersenne_twister_vector_init(vector, N);
         }
-        ok |= mersenne_twister_vector_update(vector);
+        ok &= mersenne_twister_vector_update(vector);
         idx = 0;
     }
     assert(ok);

Original file line number	Diff line number	Diff line change
`@@ -73,9 +73,9 @@ unsigned int mersenne_twister() {`
`73`	`73`	`bool ok = true;`
`74`	`74`	`if (static_cast<unsigned int>(idx) >= N) {`
`75`	`75`	`if (static_cast<unsigned int>(idx) > N) {`
`76`		`- ok \|= mersenne_twister_vector_init(vector, N);`
	`76`	`+ ok &= mersenne_twister_vector_init(vector, N);`
`77`	`77`	`}`
`78`		`- ok \|= mersenne_twister_vector_update(vector);`
	`78`	`+ ok &= mersenne_twister_vector_update(vector);`
`79`	`79`	`idx = 0;`
`80`	`80`	`}`
`81`	`81`	`assert(ok);`