From 2fd0c8d2c2d18b010e98db6bcd4360723494b539 Mon Sep 17 00:00:00 2001 From: Guillermo Guerrero Date: Tue, 17 Jun 2025 10:54:32 +0200 Subject: [PATCH 1/3] return always a NeedUpdateResult. --- packages/react-native-version-check/src/needUpdate.js | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/packages/react-native-version-check/src/needUpdate.js b/packages/react-native-version-check/src/needUpdate.js index 6ecfbf28..583c0bf8 100644 --- a/packages/react-native-version-check/src/needUpdate.js +++ b/packages/react-native-version-check/src/needUpdate.js @@ -90,6 +90,13 @@ export default async function needUpdate( } catch (e) { if (option.ignoreErrors) { console.warn(e); // eslint-disable-line no-console + + return Promise.resolve({ + isNeeded: false, + storeUrl: providerStoreUrl, + currentVersion: option.currentVersion, + latestVersion: '', + }); } else { throw e; } From dcfa5e7765a74ec161800b901e935d5bee78ae07 Mon Sep 17 00:00:00 2001 From: Guillermo Guerrero Date: Tue, 17 Jun 2025 11:04:18 +0200 Subject: [PATCH 2/3] return empty string. --- packages/react-native-version-check/src/getLatestVersion.js | 1 + 1 file changed, 1 insertion(+) diff --git a/packages/react-native-version-check/src/getLatestVersion.js b/packages/react-native-version-check/src/getLatestVersion.js index ce6b234f..426e108b 100644 --- a/packages/react-native-version-check/src/getLatestVersion.js +++ b/packages/react-native-version-check/src/getLatestVersion.js @@ -56,6 +56,7 @@ export async function getLatestVersion( } catch (e) { if (option.ignoreErrors) { console.warn(e); // eslint-disable-line no-console + return Promise.resolve(''); } else { throw e; } From ed6438dfacd8cb2d8e8a5c1ec38061292b7e2bd5 Mon Sep 17 00:00:00 2001 From: Guillermo Guerrero Date: Tue, 17 Jun 2025 11:36:03 +0200 Subject: [PATCH 3/3] Fixed documentation with correct parameters. --- README.md | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/README.md b/README.md index 6fbda8d5..b47b98f5 100644 --- a/README.md +++ b/README.md @@ -201,7 +201,7 @@ VersionCheck.needUpdate({ fetchOptions | _object_ | isomorphic-fetch options (https://github.github.io/fetch/) ignoreErrors | _boolean_ | true -- #**`needUpdate([option: Object])`** _(Promise)_ - Returns an object contains with boolean value whether update needed, current version and latest version. Current and the latest app versions are first split by delimiter, and check each split numbers into depth. +- #**`needUpdate([option: NeedUpdateOption])`** _(Promise)_ - Returns an object contains with boolean value whether update needed, current version and latest version. Current and the latest app versions are first split by delimiter, and check each split numbers into depth. - Option Field | Type | Default @@ -209,9 +209,6 @@ VersionCheck.needUpdate({ currentVersion | _string_ | app's current version from [getCurrentVersion()](#getCurrentVersion) latestVersion | _string_ | app's latest version from [getLatestVersion()](#getLatestVersion) depth | _number_ | ```Infinity``` - forceUpdate | _boolean_ | ```false``` - provider | _string_ or _function_ | provider name or function that returns promise or value of the latest version - fetchOptions | _object_ | isomorphic-fetch options (https://github.github.io/fetch/) ignoreErrors | _boolean_ | true - Result