Added: Showing error for Custom Character Properties when the given character is empty

Author: kleber-swf

Editor/BitmapFontCreator.cs

@@ -9,14 +9,10 @@ internal static class BitmapFontCreator
 	{
 		private const char IgnoreCharacter = ' ';
 
-		public static void TryCreateFont(ExecutionData data, bool warnBeforeOverwrite)
+		public static bool TryCreateFont(ExecutionData data, bool warnBeforeOverwrite, out string error)
 		{
-			var error = CheckForErrors(data);
-			if (!string.IsNullOrEmpty(error))
-			{
-				Debug.LogError(error);
-				return;
-			}
+			error = CheckForErrors(data);
+			if (!string.IsNullOrEmpty(error)) return false;
 
 			var path = AssetDatabase.GetAssetPath(data.Texture);
 			var baseName = Path.GetFileNameWithoutExtension(path);
@@ -27,16 +23,18 @@ public static void TryCreateFont(ExecutionData data, bool warnBeforeOverwrite)
 			if (warnBeforeOverwrite && !(AssetDatabase.GUIDFromAssetPath(materialPath) == null && AssetDatabase.GUIDFromAssetPath(fontPath) == null))
 			{
 				if (!EditorUtility.DisplayDialog("Warning", "Asset already exists. Overwrite? (It will keep the references)", "Yes", "No"))
-					return;
+					return false;
 			}
 
 			var material = CreateMaterial(baseName, data.Texture);
-			var font = CreateFontAsset(baseName, material, data);
+			var font = CreateFontAsset(baseName, material, data, out error);
+			if (!string.IsNullOrEmpty(error)) return false;
 
 			AssetDatabase.CreateAsset(material, materialPath);
 			CreateOrReplaceAsset(font, fontPath);
 
 			AssetDatabase.Refresh();
+			return true;
 		}
 
 		private static string CheckForErrors(ExecutionData data)
@@ -62,11 +60,20 @@ private static Material CreateMaterial(string baseName, Texture2D texture)
 			};
 		}
 
-		private static Font CreateFontAsset(string baseName, Material material, ExecutionData data)
+		private static Font CreateFontAsset(string baseName, Material material, ExecutionData data, out string error)
 		{
+			error = null;
 			var map = new Dictionary<char, CharacterProps>();
-			foreach (var e in data.CustomCharacterProps)
+			for (var i = 0; i < data.CustomCharacterProps.Count; i++)
+			{
+				var e = data.CustomCharacterProps[i];
+				if (string.IsNullOrEmpty(e.Character))
+				{
+					error = $"Character for Custom Character Properties at position {i + 1} is empty";
+					return null;
+				}
 				map.Add(e.Character[0], e);
+			}
 
 			return new Font(baseName)
 			{

Editor/Model/BitmapFontCreatorModel.cs

@@ -74,11 +74,7 @@ private void UpdateChacters()
 		}
 
 		public void OnBeforeSerialize() { }
-		public void OnAfterDeserialize()
-		{
-			Debug.Log("Deserializing");
-			UpdateChacters();
-		}
+		public void OnAfterDeserialize() { UpdateChacters(); }
 	}
 
 	internal class ExecutionData : BitmapFontCreatorData

Editor/UI/BitmapFontCreatorEditor.cs

@@ -12,6 +12,7 @@ public class BitmapFontCreatorEditor : EditorWindow
 		private ProfilesView _profilesView;
 		private PrefsView _prefsView;
 		private Settings _settings;
+		private string _error;
 
 		private Vector2 _charactersScrollPos = Vector2.zero;
 		private Vector2 _mainScrollPos = Vector2.zero;
@@ -89,6 +90,14 @@ private void OnGUI()
 			GUILayout.FlexibleSpace();
 
 			DrawBottomMenu();
+
+			if (!string.IsNullOrEmpty(_error)) ShowCurrentError();
+		}
+
+		private void ShowCurrentError()
+		{
+			Debug.LogError(_error);
+			_error = null;
 		}
 
 		private void DrawTextureField()
@@ -130,9 +139,8 @@ private void DrawCreateFontButton()
 			GUILayout.BeginHorizontal();
 			GUILayout.FlexibleSpace();
 			GUI.color = Color.cyan;
-
 			if (GUILayout.Button(UI.CreateButton, Styles.CreateButton))
-				BitmapFontCreator.TryCreateFont(_data, _prefsView.Model.WarnOnReplaceFont);
+				BitmapFontCreator.TryCreateFont(_data, _prefsView.Model.WarnOnReplaceFont, out _error);
 
 			GUI.color = Color.white;
 			GUILayout.FlexibleSpace();