Skip to content

Commit b7dc358

Browse files
webnsjeromegamez
authored andcommitted
Remove SensitiveParameter attribute
1 parent 2de5c2c commit b7dc358

File tree

2 files changed

+4
-12
lines changed

2 files changed

+4
-12
lines changed

src/Firebase/AppCheck/AppCheckTokenGenerator.php

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,6 +11,8 @@
1111

1212
/**
1313
* @internal
14+
*
15+
* @todo Add #[SensitiveParameter] attribute to the private key once the minimum required PHP version is >=8.2
1416
*/
1517
final class AppCheckTokenGenerator
1618
{
@@ -24,7 +26,6 @@ final class AppCheckTokenGenerator
2426
*/
2527
public function __construct(
2628
private readonly string $clientEmail,
27-
#[\SensitiveParameter]
2829
private readonly string $privateKey,
2930
?ClockInterface $clock = null,
3031
) {

src/Firebase/ServiceAccount.php

Lines changed: 2 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -6,44 +6,35 @@
66

77
/**
88
* @internal
9+
*
10+
* @todo Add #[SensitiveParameter] attributes once the minimum required PHP version is >=8.2
911
*/
1012
final class ServiceAccount
1113
{
1214
public function __construct(
1315
/** @var non-empty-string */
1416
public string $type,
1517
/** @var non-empty-string */
16-
#[\SensitiveParameter]
1718
public string $projectId,
1819
/** @var non-empty-string */
19-
#[\SensitiveParameter]
2020
public string $clientEmail,
2121
/** @var non-empty-string */
22-
#[\SensitiveParameter]
2322
public string $privateKey,
2423
/** @var non-empty-string|null */
25-
#[\SensitiveParameter]
2624
public ?string $clientId = null,
2725
/** @var non-empty-string|null */
28-
#[\SensitiveParameter]
2926
public ?string $privateKeyId = null,
3027
/** @var non-empty-string|null */
31-
#[\SensitiveParameter]
3228
public ?string $authUri = null,
3329
/** @var non-empty-string|null */
34-
#[\SensitiveParameter]
3530
public ?string $tokenUri = null,
3631
/** @var non-empty-string|null */
37-
#[\SensitiveParameter]
3832
public ?string $authProviderX509CertUrl = null,
3933
/** @var non-empty-string|null */
40-
#[\SensitiveParameter]
4134
public ?string $clientX509CertUrl = null,
4235
/** @var non-empty-string|null */
43-
#[\SensitiveParameter]
4436
public ?string $quotaProjectId = null,
4537
/** @var non-empty-string|null */
46-
#[\SensitiveParameter]
4738
public ?string $universeDomain = null,
4839
) {
4940
}

0 commit comments

Comments
 (0)