From 07923881c3c22d500bbe2fb2a787189971451cb3 Mon Sep 17 00:00:00 2001 From: Nikita Sklyarov Date: Wed, 26 Nov 2025 21:53:46 +0200 Subject: [PATCH] Remove SensitiveParameter attribute --- src/Firebase/AppCheck/AppCheckTokenGenerator.php | 3 ++- src/Firebase/ServiceAccount.php | 13 ++----------- 2 files changed, 4 insertions(+), 12 deletions(-) diff --git a/src/Firebase/AppCheck/AppCheckTokenGenerator.php b/src/Firebase/AppCheck/AppCheckTokenGenerator.php index c44fc19bb..eef566ce0 100644 --- a/src/Firebase/AppCheck/AppCheckTokenGenerator.php +++ b/src/Firebase/AppCheck/AppCheckTokenGenerator.php @@ -11,6 +11,8 @@ /** * @internal + * + * @todo Add #[SensitiveParameter] attribute to the private key once the minimum required PHP version is >=8.2 */ final class AppCheckTokenGenerator { @@ -24,7 +26,6 @@ final class AppCheckTokenGenerator */ public function __construct( private readonly string $clientEmail, - #[\SensitiveParameter] private readonly string $privateKey, ?ClockInterface $clock = null, ) { diff --git a/src/Firebase/ServiceAccount.php b/src/Firebase/ServiceAccount.php index f9f1858cf..c6251a8c7 100644 --- a/src/Firebase/ServiceAccount.php +++ b/src/Firebase/ServiceAccount.php @@ -6,6 +6,8 @@ /** * @internal + * + * @todo Add #[SensitiveParameter] attributes once the minimum required PHP version is >=8.2 */ final class ServiceAccount { @@ -13,37 +15,26 @@ public function __construct( /** @var non-empty-string */ public string $type, /** @var non-empty-string */ - #[\SensitiveParameter] public string $projectId, /** @var non-empty-string */ - #[\SensitiveParameter] public string $clientEmail, /** @var non-empty-string */ - #[\SensitiveParameter] public string $privateKey, /** @var non-empty-string|null */ - #[\SensitiveParameter] public ?string $clientId = null, /** @var non-empty-string|null */ - #[\SensitiveParameter] public ?string $privateKeyId = null, /** @var non-empty-string|null */ - #[\SensitiveParameter] public ?string $authUri = null, /** @var non-empty-string|null */ - #[\SensitiveParameter] public ?string $tokenUri = null, /** @var non-empty-string|null */ - #[\SensitiveParameter] public ?string $authProviderX509CertUrl = null, /** @var non-empty-string|null */ - #[\SensitiveParameter] public ?string $clientX509CertUrl = null, /** @var non-empty-string|null */ - #[\SensitiveParameter] public ?string $quotaProjectId = null, /** @var non-empty-string|null */ - #[\SensitiveParameter] public ?string $universeDomain = null, ) { }