review: explanation of dashboard overlay

Signed-off-by: Kimonas Sotirchos <[email protected]>

Author: kimwnasptd

README.md

@@ -62,6 +62,12 @@ perform the following actions:
     * The [`NetworkPolicy`](https://github.com/kubeflow/manifests/blob/v1.10-branch/common/networkpolicies/base/centraldashboard.yaml) from the `kubeflow/manifests` repo, of the CentralDashboard, will be removed
 2. Install the manifests from this repository for the Dashboard, Profiles Controller and PodDefaults webhook
 
+> **NOTE**: The script will use the `overlays/kserve` for the Dashboard, since this is what was also used by the 1.10.2 manifests
+> [`[1]`](https://github.com/kubeflow/manifests/blob/v1.10.2/example/kustomization.yaml#L74)
+> [`[2]`](https://github.com/kubeflow/manifests/blob/v1.10.2/applications/centraldashboard/overlays/oauth2-proxy/kustomization.yaml#L6).
+> This means that the dashboard will have a link to the models web app, and expects it to be deployed. If this is not the case for your cluster, you should instead deploy
+> the dashboard using the `overlays/istio` overlay.
+
 ```bash
 ./scripts/upgrade_v1_to_v2.sh
 ```

scripts/upgrade_v1_to_v2.sh

@@ -83,7 +83,7 @@ echo -e "Successfully applied the Profile Controller component!"
 echo -e "\nApplying Dashboard component..."
 echo -e "--------------------------------"
 kustomize build \
-  $SCRIPT_DIR/../components/centraldashboard/manifests/overlays/istio \
+  $SCRIPT_DIR/../components/centraldashboard/manifests/overlays/kserve \
   | kubectl apply -f -
 
 echo "Waiting for Dashboard Deployment to become available..."