-
Notifications
You must be signed in to change notification settings - Fork 68
Open
Labels
kind/plan-taskkind - planning - taskkind - planning - task
Description
Certification
- I certify I am an Epic Owner for Kubeflow Notebooks 2.0 and expected to create planning-related issues.
Description
🛑 This issue is dependent upon completion of #677
Work was originally performed to include a clusterMetrics object on the API response for GET /workspacekinds
That commit had a few // TODO comments that we want to address as part of this work:
- https://github.com/kubeflow/notebooks/pull/368/files#diff-5a4650065c6e40d76e86fc1df9189efbbdc0d93250c74928b71601e13eac2890R65
- https://github.com/kubeflow/notebooks/pull/368/files#diff-5a4650065c6e40d76e86fc1df9189efbbdc0d93250c74928b71601e13eac2890R110
- https://github.com/kubeflow/notebooks/pull/368/files#diff-5a4650065c6e40d76e86fc1df9189efbbdc0d93250c74928b71601e13eac2890R130
When the namespaceFilter query parameter is provided to the GET /workspacekinds endpoint - the following behavior should occur:
clusterMetricsattribute is omitted from API responsenamespaceMetricsattribute is included in API response- "counts" for the
namespaceMetricsshould be scoped to only the specifiednamespaceas provided in?namespaceFilter
namespaceMetrics should be typed and handled similarly as clusterMetrics
Acceptance Criteria
- when
?namespaceFilterquery parameter IS NOT provided:clusterMetricsattribute included inGET /workspacekindsAPI responsecountsincluded reflect data across all namespaces
namespaceMetricsattribute omitted inGET /workspacekindsAPI response
- when
?namespaceFilterquery parameter IS provided:namespaceMetricsattribute included inGET /workspacekindsAPI responsecountsincluded reflect data specific to namespace provided in?namespaceFilter
clusterMetricsattribute omitted inGET /workspacekindsAPI response
Metadata
Metadata
Assignees
Labels
kind/plan-taskkind - planning - taskkind - planning - task
Type
Projects
Status
Needs Triage