Skip to content

Conversation

jenny-s51
Copy link
Member

@jenny-s51 jenny-s51 commented Jul 9, 2025

Summary

Adds support for PatternFly utility classes.

Changes

  • Added @patternfly/patternfly/patternfly-addons.css import to App.tsx
  • Enables usage of PatternFly utility classes throughout the application (spacing, display, text, sizing, flex, background, etc.)

Benefits

  • Provides access to PatternFly's comprehensive utility class system
  • Prevents inline/custom CSS for common styling patterns

Testing Instructions

  1. Add className="pf-v6-u-text-color-brand" to the Title component on line 54 of workspaces/frontend/src/app/App.tsx:
    <Title headingLevel="h2" size="3xl" className="pf-v6-u-text-color-brand">
      Kubeflow Notebooks 2.0
    </Title>
  2. Save the file and verify the application title text appears in blue (PatternFly brand color)
  3. Remove the test class when verification is complete

Related

@github-project-automation github-project-automation bot moved this to Needs Triage in Kubeflow Notebooks Jul 9, 2025
@google-oss-prow google-oss-prow bot added area/frontend area - related to frontend components area/v2 area - version - kubeflow notebooks v2 labels Jul 9, 2025
@jenny-s51
Copy link
Member Author

/assign

@jenny-s51 jenny-s51 force-pushed the add-PF-utility-classes branch from 7201d8c to e5471dc Compare July 9, 2025 20:09
@jenny-s51 jenny-s51 removed their assignment Jul 9, 2025
@jenny-s51 jenny-s51 force-pushed the add-PF-utility-classes branch from e5471dc to f6404e8 Compare July 9, 2025 20:14
Signed-off-by: Jenny <[email protected]>

chore(ws): Add support for PF utility classes
@jenny-s51 jenny-s51 force-pushed the add-PF-utility-classes branch from cde0193 to 47a0550 Compare July 9, 2025 20:27
@jenny-s51 jenny-s51 changed the title chore(deps): Add support for PF utility classes chore(ws): Add support for PF utility classes Jul 9, 2025
@paulovmr
Copy link

/ok-to-test

Copy link

@paulovmr paulovmr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Copy link
Member

@ederign ederign left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ederign

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow google-oss-prow bot merged commit 023f84b into kubeflow:notebooks-v2 Jul 10, 2025
8 of 9 checks passed
@github-project-automation github-project-automation bot moved this from Needs Triage to Done in Kubeflow Notebooks Jul 10, 2025
Noa-limoy pushed a commit to Noa-limoy/notebooks that referenced this pull request Jul 17, 2025
Signed-off-by: Jenny <[email protected]>

chore(ws): Add support for PF utility classes
bhaktinarvekar pushed a commit to bhaktinarvekar/notebooks that referenced this pull request Sep 14, 2025
Signed-off-by: Jenny <[email protected]>

chore(ws): Add support for PF utility classes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved area/frontend area - related to frontend components area/v2 area - version - kubeflow notebooks v2 lgtm ok-to-test size/XS
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants