chore: Seaweedfs as Minio replacement (#11965)

add seaweedFS to KFP as default object store

This change switches KFP's default objectstore deployment to Seaweedfs
instead of Minio. Minio is still kept as an optional deployment to 
help users with migrating. CI is updated to accommodate testing for 
Minio and SeaweedFS. Multi-User testing is also introduced, which also
includes namespace authorization testing in Seaweedfs.

Some more work is needed to completely rid the KFP backend and frontend
code of Minio specific code and labeling, which we accrue as tech debt
as part of this change. 


Signed-off-by: juliusvonkohout <[email protected]>
Signed-off-by: Julius von Kohout <[email protected]>
Signed-off-by: Harshvir Potpose <[email protected]>
Co-authored-by: Harshvir Potpose <[email protected]>
Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
Co-authored-by: pschoen-itsc <[email protected]>

Author: 4 people

.github/actions/kfp-cluster/action.yml

@@ -30,6 +30,15 @@ inputs:
   image_registry:
     required: true
     description: "Image Registry address of the images"
+  multi_user:
+    description: "If KFP should be deployed in multi-user mode"
+    required: false
+    default: 'false'
+  storage_backend:
+    description: "Storage backend to use (minio or seaweedfs)"
+    required: false
+    default: 'seaweedfs'
+
 runs:
   using: "composite"
   steps:
@@ -68,10 +77,22 @@ runs:
 
         if [ "${{ inputs.proxy }}" = "true" ]; then
           ARGS="${ARGS} --proxy"
-        elif [ "${{inputs.cache_enabled }}" = "false" ]; then
+        fi
+        
+        if [ "${{inputs.cache_enabled }}" = "false" ]; then
           ARGS="${ARGS} --cache-disabled"
-        elif [ "${{inputs.pipeline_store }}" = "kubernetes" ]; then
-          ARGS="${ARGS}  --deploy-k8s-native"
+        fi
+        
+        if [ "${{inputs.pipeline_store }}" = "kubernetes" ]; then
+          ARGS="${ARGS} --deploy-k8s-native"
+        fi
+        
+        if [ "${{ inputs.multi_user }}" = "true" ]; then
+          ARGS="${ARGS} --multi-user"
+        fi
+        
+        if [ "${{ inputs.storage_backend }}" != "seaweedfs" ]; then
+          ARGS="${ARGS} --storage ${{ inputs.storage_backend }}"
         fi
         
         ./.github/resources/scripts/deploy-kfp.sh $ARGS

.github/resources/manifests/argo/overlays/multi-user-minio/apiserver-env.yaml

@@ -0,0 +1,16 @@
+apiVersion: apps/v1
+kind: Deployment
+metadata:
+  name: ml-pipeline
+spec:
+  template:
+    spec:
+      containers:
+        - name: ml-pipeline-api-server
+          env:
+            - name: V2_DRIVER_IMAGE
+              value: kind-registry:5000/driver
+            - name: V2_LAUNCHER_IMAGE
+              value: kind-registry:5000/launcher
+            - name: LOG_LEVEL
+              value: "debug"

.github/resources/manifests/argo/overlays/multi-user-minio/kustomization.yaml

@@ -0,0 +1,19 @@
+apiVersion: kustomize.config.k8s.io/v1beta1
+kind: Kustomization
+
+resources:
+- ../../../../../../manifests/kustomize/env/platform-agnostic-multi-user-minio
+
+images:
+- name: ghcr.io/kubeflow/kfp-api-server
+  newName: kind-registry:5000/apiserver
+  newTag: latest
+- name: ghcr.io/kubeflow/kfp-persistence-agent
+  newName: kind-registry:5000/persistenceagent
+  newTag: latest
+- name: ghcr.io/kubeflow/kfp-scheduled-workflow-controller
+  newName: kind-registry:5000/scheduledworkflow
+  newTag: latest
+
+patchesStrategicMerge:
+- apiserver-env.yaml

.github/resources/manifests/argo/overlays/multi-user/apiserver-env.yaml

@@ -0,0 +1,16 @@
+apiVersion: apps/v1
+kind: Deployment
+metadata:
+  name: ml-pipeline
+spec:
+  template:
+    spec:
+      containers:
+        - name: ml-pipeline-api-server
+          env:
+            - name: V2_DRIVER_IMAGE
+              value: kind-registry:5000/driver
+            - name: V2_LAUNCHER_IMAGE
+              value: kind-registry:5000/launcher
+            - name: LOG_LEVEL
+              value: "debug"

.github/resources/manifests/argo/overlays/multi-user/kustomization.yaml

@@ -0,0 +1,19 @@
+apiVersion: kustomize.config.k8s.io/v1beta1
+kind: Kustomization
+
+resources:
+- ../../../../../../manifests/kustomize/env/platform-agnostic-multi-user
+
+images:
+- name: ghcr.io/kubeflow/kfp-api-server
+  newName: kind-registry:5000/apiserver
+  newTag: latest
+- name: ghcr.io/kubeflow/kfp-persistence-agent
+  newName: kind-registry:5000/persistenceagent
+  newTag: latest
+- name: ghcr.io/kubeflow/kfp-scheduled-workflow-controller
+  newName: kind-registry:5000/scheduledworkflow
+  newTag: latest
+
+patchesStrategicMerge:
+- apiserver-env.yaml

.github/resources/manifests/argo/overlays/no-proxy-minio/apiserver-env.yaml

@@ -0,0 +1,16 @@
+apiVersion: apps/v1
+kind: Deployment
+metadata:
+  name: ml-pipeline
+spec:
+  template:
+    spec:
+      containers:
+        - name: ml-pipeline-api-server
+          env:
+            - name: V2_DRIVER_IMAGE
+              value: kind-registry:5000/driver
+            - name: V2_LAUNCHER_IMAGE
+              value: kind-registry:5000/launcher
+            - name: LOG_LEVEL
+              value: "debug"

.github/resources/manifests/argo/overlays/no-proxy-minio/kustomization.yaml

@@ -0,0 +1,19 @@
+apiVersion: kustomize.config.k8s.io/v1beta1
+kind: Kustomization
+
+resources:
+- ../../../../../../manifests/kustomize/env/platform-agnostic-minio
+
+images:
+- name: ghcr.io/kubeflow/kfp-api-server
+  newName: kind-registry:5000/apiserver
+  newTag: latest
+- name: ghcr.io/kubeflow/kfp-persistence-agent
+  newName: kind-registry:5000/persistenceagent
+  newTag: latest
+- name: ghcr.io/kubeflow/kfp-scheduled-workflow-controller
+  newName: kind-registry:5000/scheduledworkflow
+  newTag: latest
+
+patches:
+- path: apiserver-env.yaml

.github/resources/manifests/argo/overlays/no-proxy/kustomization.yaml

@@ -17,4 +17,3 @@ images:
 
 patches:
 - path: apiserver-env.yaml
-- path: workflow-disable-logs-patch.yaml

.github/resources/manifests/argo/overlays/no-proxy/workflow-disable-logs-patch.yaml

@@ -13,4 +13,6 @@ spec:
             - name: HTTPS_PROXY
               value: "http://squid.squid.svc.cluster.local:3128"
             - name: NO_PROXY
-              value: "localhost,127.0.0.1,.svc.cluster.local,kubernetes.default.svc,metadata-grpc-service,0,1,2,3,4,5,6,7,8,9"
+              value: "localhost,127.0.0.1,.svc.cluster.local,kubernetes.default.svc,minio-service.kubeflow,metadata-grpc-service,metadata-grpc-service.kubeflow,ml-pipeline.kubeflow"
+            - name: OBJECTSTORECONFIG_HOST
+              value: "minio-service.kubeflow.svc.cluster.local"