cleaning ups before PR review - 1

Signed-off-by: kaikaila <[email protected]>

Author: kaikaila

backend/src/apiserver/client_manager/client_manager.go

@@ -388,14 +388,6 @@ func ensureUniqueCompositeIndex(db *gorm.DB, model interface{}, indexName string
 	}
 }
 
-// This helper function enforces a composite unique index on a given model.
-// Refer to ensureUniqueCompositeIndex for details.
-// func ensureIndex(db *gorm.DB, model interface{}, indexName string) {
-// 	if err := db.Migrator().CreateIndex(model, indexName); err != nil {
-// 		glog.Fatalf("Failed to create index %s. Error: %s", indexName, err)
-// 	}
-// }
-
 func InitDBClient(initConnectionTimeout time.Duration) *storage.DB {
 	// Allowed driverName values:
 	// 1) To use MySQL, use `mysql`
@@ -486,22 +478,18 @@ func InitDBClient(initConnectionTimeout time.Duration) *storage.DB {
 		glog.Fatalf("Failed to update the resource reference payload type. Error: %s", response)
 	}
 
+	// Manual AddForeignKey() and AddIndex() calls have been removed.
+	// Both Methods are GORM v1 legacy which no longer exist in GORM v2.
+	// Foreign key constraints are now defined and managed by GORM via struct tags 'constraint' and 'index'.
+	// This ensures a single source of truth for schema definitions and avoids duplicate or out-of-sync DDL.
+
+	// The ensureUniqueCompositeIndex() method is called to replace the GORM v1 legacy AddUniqueIndex method.
 	ensureUniqueCompositeIndex(db, &model.Pipeline{}, "namespace_name")
 	ensureUniqueCompositeIndex(db, &model.Experiment{}, "idx_name_namespace")
 	ensureUniqueCompositeIndex(db, &model.PipelineVersion{}, "idx_pipelineid_name")
 
-	// ensureIndex(db, &model.Run{}, "experimentuuid_createatinsec")
-	// ensureIndex(db, &model.Run{}, "experimentuuid_conditions_finishedatinsec")
-	// ensureIndex(db, &model.Run{}, "namespace_createatinsec")
-	// ensureIndex(db, &model.Run{}, "namespace_conditions_finishedatinsec")
-
-	// Manual AddForeignKey() calls have been removed.
-	// Foreign key constraints are now defined and managed by GORM via struct tags 'constraint'
-	// on RunMetric.RunUUID, PipelineVersion.PipelineId, Task.RunUUID, etc.).
-	// This ensures a single source of truth for schema definitions and avoids duplicate or out-of-sync DDL.
-
 	// Removed invalid ModifyColumn on Job.WorkflowSpecManifest.
-	// This field never existed on Job; original reference likely confused with PipelineSpec.
+	// This field does not exist on Job; original reference likely confused with PipelineSpec.
 
 	// Data backfill for pipeline_versions if this is the first time for
 	// pipeline_versions to enter mlpipeline DB.

backend/src/apiserver/model/experiment.go

@@ -20,7 +20,7 @@ type Experiment struct {
 	Description           string       `gorm:"column:Description; not null;"`
 	CreatedAtInSec        int64        `gorm:"column:CreatedAtInSec; not null;"`
 	LastRunCreatedAtInSec int64        `gorm:"column:LastRunCreatedAtInSec; not null;"`
-	Namespace             string       `gorm:"column:Namespace; not null; uniqueIndex:idx_name_namespace; type:varchar(255)"`
+	Namespace             string       `gorm:"column:Namespace; not null; uniqueIndex:idx_name_namespace; type:varchar(63)"`
 	StorageState          StorageState `gorm:"column:StorageState; not null;"`
 }
 

backend/src/apiserver/model/pipeline.go

@@ -33,15 +33,15 @@ const (
 type Pipeline struct {
 	UUID           string `gorm:"column:UUID; not null; primaryKey;"`
 	CreatedAtInSec int64  `gorm:"column:CreatedAtInSec; not null;"`
-	Name           string `gorm:"column:Name; not null; uniqueIndex:namespace_name; size:191"` // Index improves performance of the List ang Get queries
+	Name           string `gorm:"column:Name; not null; uniqueIndex:namespace_name; type:varchar(191);"` // Index improves performance of the List ang Get queries
 	DisplayName    string `gorm:"column:DisplayName; not null"`
 	Description    string `gorm:"column:Description; type:text;"` // Use type:longtext instead of size to ensure sufficient capacity
 	// TODO(gkcalat): this is deprecated. Consider removing and adding data migration logic at the server startup.
 	Parameters string         `gorm:"column:Parameters; type:text;"`
 	Status     PipelineStatus `gorm:"column:Status; not null;"`
 	// TODO(gkcalat): this is deprecated. Consider removing and adding data migration logic at the server startup.
 	DefaultVersionId string `gorm:"column:DefaultVersionId;"` // deprecated
-	Namespace        string `gorm:"column:Namespace; uniqueIndex:namespace_name; size:63;"`
+	Namespace        string `gorm:"column:Namespace; uniqueIndex:namespace_name; type:varchar(63);"`
 }
 
 func (p Pipeline) GetValueOfPrimaryKey() string {
@@ -78,11 +78,6 @@ func (p *Pipeline) APIToModelFieldMap() map[string]string {
 	return pipelineAPIToModelFieldMap
 }
 
-// TableName overrides GORM default table name inference
-func (Pipeline) TableName() string {
-	return "pipelines"
-}
-
 // GetModelName returns table name used as sort field prefix.
 func (p *Pipeline) GetModelName() string {
 	return "pipelines"

backend/src/apiserver/model/pipeline_version.go

@@ -31,8 +31,12 @@ const (
 type PipelineVersion struct {
 	UUID           string `gorm:"column:UUID; not null; primaryKey;"`
 	CreatedAtInSec int64  `gorm:"column:CreatedAtInSec; not null; index;"`
-	Name           string `gorm:"column:Name; not null; type:varchar(255); uniqueIndex:idx_pipelineid_name;"`
-	DisplayName    string `gorm:"column:DisplayName; not null"`
+	// Explicitly specify type:varchar(255) to ensure MySQL can create index on this column.
+	// In GORM v1, omitting type still allowed index creation due to default behavior.
+	// However, GORM v2 requires explicit type declaration for indexed string fields,
+	// otherwise it may default to longtext, which is not indexable in MySQL.
+	Name        string `gorm:"column:Name; not null; type:varchar(255); uniqueIndex:idx_pipelineid_name;"`
+	DisplayName string `gorm:"column:DisplayName; not null"`
 	// TODO(gkcalat): this is deprecated. Consider removing and adding data migration logic at the server startup.
 	Parameters string `gorm:"column:Parameters; not null; type:text;"` // deprecated
 	// PipelineVersion belongs to Pipeline. If a pipeline with a specific UUID