Skip to content

Commit 0f79646

Browse files
committed
Improve the field documentation of 'SparkApplication.Spec.Suspend' to make it more descriptive
Signed-off-by: Shingo Omura <[email protected]>
1 parent dd0a916 commit 0f79646

File tree

6 files changed

+21
-21
lines changed

6 files changed

+21
-21
lines changed

api/v1beta2/sparkapplication_types.go

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -35,9 +35,9 @@ type SparkApplicationSpec struct {
3535
// INSERT ADDITIONAL SPEC FIELDS - desired state of cluster
3636
// Important: Run "make generate" to regenerate code after modifying this file
3737

38-
// Suspend specifies whether the Spark operator should create Pods or not.
39-
// If a SparkApplication is created with suspend set to true, no Pods are created
40-
// by the Spark operator. If a SparkApplication is suspended after creation
38+
// Suspend indicates whether the SparkApplication should be suspended.
39+
// When true, the controller skips submitting the Spark job.
40+
// If a SparkApplication is suspended after creation
4141
// (i.e. the flag goes from false to true), the Spark operator will delete
4242
// all active Pods associated with this SparkApplication.
4343
// Users must design their Spark application to gracefully handle this.

charts/spark-operator-chart/crds/sparkoperator.k8s.io_scheduledsparkapplications.yaml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -10572,9 +10572,9 @@ spec:
1057210572
type: string
1057310573
suspend:
1057410574
description: |-
10575-
Suspend specifies whether the Spark operator should create Pods or not.
10576-
If a SparkApplication is created with suspend set to true, no Pods are created
10577-
by the Spark operator. If a SparkApplication is suspended after creation
10575+
Suspend indicates whether the SparkApplication should be suspended.
10576+
When true, the controller skips submitting the Spark job.
10577+
If a SparkApplication is suspended after creation
1057810578
(i.e. the flag goes from false to true), the Spark operator will delete
1057910579
all active Pods associated with this SparkApplication.
1058010580
Users must design their Spark application to gracefully handle this.

charts/spark-operator-chart/crds/sparkoperator.k8s.io_sparkapplications.yaml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -10493,9 +10493,9 @@ spec:
1049310493
type: string
1049410494
suspend:
1049510495
description: |-
10496-
Suspend specifies whether the Spark operator should create Pods or not.
10497-
If a SparkApplication is created with suspend set to true, no Pods are created
10498-
by the Spark operator. If a SparkApplication is suspended after creation
10496+
Suspend indicates whether the SparkApplication should be suspended.
10497+
When true, the controller skips submitting the Spark job.
10498+
If a SparkApplication is suspended after creation
1049910499
(i.e. the flag goes from false to true), the Spark operator will delete
1050010500
all active Pods associated with this SparkApplication.
1050110501
Users must design their Spark application to gracefully handle this.

config/crd/bases/sparkoperator.k8s.io_scheduledsparkapplications.yaml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -10572,9 +10572,9 @@ spec:
1057210572
type: string
1057310573
suspend:
1057410574
description: |-
10575-
Suspend specifies whether the Spark operator should create Pods or not.
10576-
If a SparkApplication is created with suspend set to true, no Pods are created
10577-
by the Spark operator. If a SparkApplication is suspended after creation
10575+
Suspend indicates whether the SparkApplication should be suspended.
10576+
When true, the controller skips submitting the Spark job.
10577+
If a SparkApplication is suspended after creation
1057810578
(i.e. the flag goes from false to true), the Spark operator will delete
1057910579
all active Pods associated with this SparkApplication.
1058010580
Users must design their Spark application to gracefully handle this.

config/crd/bases/sparkoperator.k8s.io_sparkapplications.yaml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -10493,9 +10493,9 @@ spec:
1049310493
type: string
1049410494
suspend:
1049510495
description: |-
10496-
Suspend specifies whether the Spark operator should create Pods or not.
10497-
If a SparkApplication is created with suspend set to true, no Pods are created
10498-
by the Spark operator. If a SparkApplication is suspended after creation
10496+
Suspend indicates whether the SparkApplication should be suspended.
10497+
When true, the controller skips submitting the Spark job.
10498+
If a SparkApplication is suspended after creation
1049910499
(i.e. the flag goes from false to true), the Spark operator will delete
1050010500
all active Pods associated with this SparkApplication.
1050110501
Users must design their Spark application to gracefully handle this.

docs/api-docs.md

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -244,9 +244,9 @@ bool
244244
</em>
245245
</td>
246246
<td>
247-
<p>Suspend specifies whether the Spark operator should create Pods or not.
248-
If a SparkApplication is created with suspend set to true, no Pods are created
249-
by the Spark operator. If a SparkApplication is suspended after creation
247+
<p>Suspend indicates whether the SparkApplication should be suspended.
248+
When true, the controller skips submitting the Spark job.
249+
If a SparkApplication is suspended after creation
250250
(i.e. the flag goes from false to true), the Spark operator will delete
251251
all active Pods associated with this SparkApplication.
252252
Users must design their Spark application to gracefully handle this.</p>
@@ -2359,9 +2359,9 @@ bool
23592359
</em>
23602360
</td>
23612361
<td>
2362-
<p>Suspend specifies whether the Spark operator should create Pods or not.
2363-
If a SparkApplication is created with suspend set to true, no Pods are created
2364-
by the Spark operator. If a SparkApplication is suspended after creation
2362+
<p>Suspend indicates whether the SparkApplication should be suspended.
2363+
When true, the controller skips submitting the Spark job.
2364+
If a SparkApplication is suspended after creation
23652365
(i.e. the flag goes from false to true), the Spark operator will delete
23662366
all active Pods associated with this SparkApplication.
23672367
Users must design their Spark application to gracefully handle this.</p>

0 commit comments

Comments
 (0)