Add OpenStack LoadBalancerClass config endpoint (#7596)

* Add OpenStack LoadBalancerClass config endpoint and update routes

* Remove OpenStack floating networks endpoint and associated code and resolved other comments

Author: SheryarButt

modules/api/cmd/kubermatic-api/swagger.json

@@ -21448,6 +21448,110 @@
         }
       }
     },
+    "/api/v2/projects/{project_id}/providers/openstack/membersubnets": {
+      "get": {
+        "description": "Lists load balancer member subnets from openstack",
+        "produces": [
+          "application/json"
+        ],
+        "tags": [
+          "openstack"
+        ],
+        "operationId": "listProjectOpenstackMemberSubnets",
+        "parameters": [
+          {
+            "type": "string",
+            "name": "Username",
+            "in": "header"
+          },
+          {
+            "type": "string",
+            "name": "Password",
+            "in": "header"
+          },
+          {
+            "type": "string",
+            "name": "Domain",
+            "in": "header"
+          },
+          {
+            "type": "string",
+            "name": "OpenstackTenant",
+            "in": "header"
+          },
+          {
+            "type": "string",
+            "name": "OpenstackTenantID",
+            "in": "header"
+          },
+          {
+            "type": "string",
+            "name": "OpenstackProject",
+            "in": "header"
+          },
+          {
+            "type": "string",
+            "name": "OpenstackProjectID",
+            "in": "header"
+          },
+          {
+            "type": "string",
+            "name": "DatacenterName",
+            "in": "header"
+          },
+          {
+            "type": "string",
+            "name": "ApplicationCredentialID",
+            "in": "header"
+          },
+          {
+            "type": "string",
+            "name": "ApplicationCredentialSecret",
+            "in": "header"
+          },
+          {
+            "type": "boolean",
+            "name": "OIDCAuthentication",
+            "in": "header"
+          },
+          {
+            "type": "string",
+            "name": "Credential",
+            "in": "header"
+          },
+          {
+            "type": "string",
+            "x-go-name": "NetworkID",
+            "name": "network_id",
+            "in": "query"
+          },
+          {
+            "type": "string",
+            "x-go-name": "ProjectID",
+            "name": "project_id",
+            "in": "path",
+            "required": true
+          }
+        ],
+        "responses": {
+          "200": {
+            "description": "OpenStackLoadBalancerPoolMember",
+            "schema": {
+              "type": "array",
+              "items": {
+                "$ref": "#/definitions/OpenStackLoadBalancerPoolMember"
+              }
+            }
+          },
+          "default": {
+            "description": "errorResponse",
+            "schema": {
+              "$ref": "#/definitions/errorResponse"
+            }
+          }
+        }
+      }
+    },
     "/api/v2/projects/{project_id}/providers/openstack/networks": {
       "get": {
         "description": "Lists networks from openstack",
@@ -38177,6 +38281,20 @@
       },
       "x-go-package": "k8c.io/dashboard/v2/pkg/api/v2"
     },
+    "OpenStackLoadBalancerPoolMember": {
+      "type": "object",
+      "properties": {
+        "id": {
+          "type": "string",
+          "x-go-name": "ID"
+        },
+        "name": {
+          "type": "string",
+          "x-go-name": "Name"
+        }
+      },
+      "x-go-package": "k8c.io/dashboard/v2/pkg/api/v2"
+    },
     "Openstack": {
       "type": "object",
       "properties": {
@@ -38609,6 +38727,14 @@
           "description": "Name is human-readable name for the subnet",
           "type": "string",
           "x-go-name": "Name"
+        },
+        "tags": {
+          "description": "Tags are Neutron subnet tags (if supported by the deployment)",
+          "type": "array",
+          "items": {
+            "type": "string"
+          },
+          "x-go-name": "Tags"
         }
       },
       "x-go-package": "k8c.io/dashboard/v2/pkg/api/v1"

modules/api/pkg/api/v1/types.go

@@ -768,6 +768,8 @@ type OpenstackSubnet struct {
 	Name string `json:"name"`
 	// IPversion is the IP protocol version (4 or 6)
 	IPVersion int `json:"ipVersion"`
+	// Tags are Neutron subnet tags (if supported by the deployment)
+	Tags []string `json:"tags,omitempty"`
 }
 
 // OpenstackTenant is the object representing a openstack tenant.

modules/api/pkg/api/v2/types.go

@@ -1852,6 +1852,24 @@ type OpenstackSubnetPool struct {
 	Prefixes []string `json:"prefixes"`
 }
 
+type OpenStackLoadBalancer struct {
+	ID    string                      `json:"id"`
+	Name  string                      `json:"name"`
+	Pools []OpenStackLoadBalancerPool `json:"pools"`
+}
+
+type OpenStackLoadBalancerPool struct {
+	Name    string                            `json:"name"`
+	ID      string                            `json:"id"`
+	Members []OpenStackLoadBalancerPoolMember `json:"members"`
+}
+
+// swagger:model OpenStackLoadBalancerPoolMember
+type OpenStackLoadBalancerPoolMember struct {
+	Name string `json:"name"`
+	ID   string `json:"id"`
+}
+
 // OpenstackServerGroup is the object representing a openstack server group.
 // swagger:model OpenstackServerGroup
 type OpenstackServerGroup struct {

modules/api/pkg/handler/common/provider/openstack.go

@@ -19,6 +19,7 @@ package provider
 import (
 	"context"
 	"crypto/x509"
+	"encoding/json"
 	"fmt"
 	"net/http"
 
@@ -243,6 +244,7 @@ func GetOpenstackSubnets(ctx context.Context, userInfo *provider.UserInfo, seeds
 			ID:        subnet.ID,
 			Name:      subnet.Name,
 			IPVersion: subnet.IPVersion,
+			Tags:      subnet.Tags,
 		})
 	}
 
@@ -449,6 +451,53 @@ func GetOpenstackServerGroups(ctx context.Context, userInfo *provider.UserInfo,
 	return apiServerGroups, nil
 }
 
+func GetOpenstackLoadBalancers(ctx context.Context, userInfo *provider.UserInfo, seedsGetter provider.SeedsGetter, credentials *resources.OpenstackCredentials, datacenterName, vipNetworkID string, caBundle *x509.CertPool) ([]apiv2.OpenStackLoadBalancer, error) {
+	authURL, region, err := getOpenstackAuthURLAndRegion(userInfo, seedsGetter, datacenterName)
+	if err != nil {
+		return nil, err
+	}
+
+	loadBalancers, err := openstack.GetLoadBalancers(ctx, authURL, region, vipNetworkID, credentials, caBundle)
+	if err != nil {
+		return nil, err
+	}
+
+	apiLoadBalancers := []apiv2.OpenStackLoadBalancer{}
+	b, err := json.Marshal(loadBalancers)
+	if err != nil {
+		return nil, err
+	}
+	if err := json.Unmarshal(b, &apiLoadBalancers); err != nil {
+		return nil, err
+	}
+
+	return apiLoadBalancers, nil
+}
+
+func GetOpenstackLoadBalancerPoolMembers(ctx context.Context, userInfo *provider.UserInfo, seedsGetter provider.SeedsGetter, credentials *resources.OpenstackCredentials, datacenterName, poolID string, caBundle *x509.CertPool) ([]apiv2.OpenStackLoadBalancerPoolMember, error) {
+	authURL, region, err := getOpenstackAuthURLAndRegion(userInfo, seedsGetter, datacenterName)
+	if err != nil {
+		return nil, err
+	}
+
+	members, err := openstack.GetLoadBalancerPoolMembers(ctx, authURL, region, poolID, credentials, caBundle)
+	if err != nil {
+		return nil, err
+	}
+
+	apiMembers := []apiv2.OpenStackLoadBalancerPoolMember{}
+	for _, member := range members {
+		apiMember := apiv2.OpenStackLoadBalancerPoolMember{
+			ID:   member.ID,
+			Name: member.Name,
+		}
+
+		apiMembers = append(apiMembers, apiMember)
+	}
+
+	return apiMembers, nil
+}
+
 func getClusterForOpenstack(ctx context.Context, projectProvider provider.ProjectProvider, privilegedProjectProvider provider.PrivilegedProjectProvider, userInfoGetter provider.UserInfoGetter, projectID string, clusterID string) (*kubermaticv1.Cluster, error) {
 	cluster, err := handlercommon.GetCluster(ctx, projectProvider, privilegedProjectProvider, userInfoGetter, projectID, clusterID, &provider.ClusterGetOptions{CheckInitStatus: true})
 	if err != nil {

modules/api/pkg/handler/v2/provider/openstack.go

@@ -19,6 +19,7 @@ package provider
 import (
 	"context"
 	"crypto/x509"
+	"encoding/json"
 	"fmt"
 	"net/http"
 	"strconv"
@@ -27,6 +28,7 @@ import (
 	"github.com/go-kit/kit/endpoint"
 
 	apiv1 "k8c.io/dashboard/v2/pkg/api/v1"
+	apiv2 "k8c.io/dashboard/v2/pkg/api/v2"
 	handlercommon "k8c.io/dashboard/v2/pkg/handler/common"
 	providercommon "k8c.io/dashboard/v2/pkg/handler/common/provider"
 	"k8c.io/dashboard/v2/pkg/handler/middleware"
@@ -376,6 +378,47 @@ func OpenstackSubnetPoolEndpoint(seedsGetter provider.SeedsGetter, presetProvide
 	}
 }
 
+func OpenstackMemberSubnetsEndpoint(seedsGetter provider.SeedsGetter, presetProvider provider.PresetProvider,
+	userInfoGetter provider.UserInfoGetter, caBundle *x509.CertPool) endpoint.Endpoint {
+	return func(ctx context.Context, request interface{}) (interface{}, error) {
+		req, ok := request.(OpenstackProjectMemberSubnetReq)
+		if !ok {
+			return nil, utilerrors.NewBadRequest("invalid request")
+		}
+
+		userInfo, cred, err := GetOpenstackAuthInfo(ctx, req.OpenstackReq, req.GetProjectID(), userInfoGetter, presetProvider)
+		if err != nil {
+			return nil, err
+		}
+
+		loadbalancers, err := providercommon.GetOpenstackLoadBalancers(ctx, userInfo, seedsGetter, cred, req.DatacenterName, req.NetworkID, caBundle)
+		if err != nil {
+			return nil, err
+		}
+
+		out := make([]apiv2.OpenStackLoadBalancerPoolMember, 0)
+		for _, lb := range loadbalancers {
+			for _, pool := range lb.Pools {
+				members, err := providercommon.GetOpenstackLoadBalancerPoolMembers(ctx, userInfo, seedsGetter, cred, req.DatacenterName, pool.ID, caBundle)
+				if err != nil {
+					return nil, err
+				}
+				b, err := json.Marshal(members)
+				if err != nil {
+					return nil, err
+				}
+				var m []apiv2.OpenStackLoadBalancerPoolMember
+				if err := json.Unmarshal(b, &m); err != nil {
+					return nil, err
+				}
+				out = append(out, m...)
+			}
+		}
+
+		return out, nil
+	}
+}
+
 // openstackNoCredentialsReq represent a request for openstack
 // swagger:parameters listOpenstackSizesNoCredentialsV2 listOpenstackTenantsNoCredentialsV2 listOpenstackNetworksNoCredentialsV2 listOpenstackSecurityGroupsNoCredentialsV2 listOpenstackAvailabilityZonesNoCredentialsV2 listOpenstackServerGroupsNoCredentials
 type openstackNoCredentialsReq struct {
@@ -581,13 +624,20 @@ type OpenstackSubnetReq struct {
 	NetworkID string `json:"network_id,omitempty"`
 }
 
-// OpenstackProjectSubnetReq represent a request for openstack subnets within the context of a KKP project.
-// swagger:parameters listProjectOpenstackSubnets
+// OpenstackProjectSubnetReq represent a request for openstack subnets (or resources requiring a network_id) within the context of a KKP project.
+// swagger:parameters listProjectOpenstackSubnets listProjectOpenstackSubnetTags
 type OpenstackProjectSubnetReq struct {
 	OpenstackSubnetReq
 	common.ProjectReq
 }
 
+// OpenstackProjectMemberSubnetReq represent a request for openstack subnets members within the context of a KKP project.
+// swagger:parameters listProjectOpenstackMemberSubnets
+type OpenstackProjectMemberSubnetReq struct {
+	OpenstackSubnetReq
+	common.ProjectReq
+}
+
 func DecodeOpenstackReq(_ context.Context, r *http.Request) (interface{}, error) {
 	var req OpenstackReq
 
@@ -702,3 +752,25 @@ func DecodeOpenstackProjectSubnetReq(c context.Context, r *http.Request) (interf
 		OpenstackSubnetReq: openstackReq.(OpenstackSubnetReq),
 	}, nil
 }
+
+func DecodeOpenstackProjectMemberSubnetReq(c context.Context, r *http.Request) (interface{}, error) {
+	projectReq, err := common.DecodeProjectRequest(c, r)
+	if err != nil {
+		return nil, err
+	}
+
+	openstackReq, err := DecodeOpenstackSubnetReq(c, r)
+	if err != nil {
+		return nil, err
+	}
+
+	networkID := r.URL.Query().Get("network_id")
+	if networkID == "" {
+		return nil, fmt.Errorf("'network_id' is a required parameter and may not be empty")
+	}
+
+	return OpenstackProjectMemberSubnetReq{
+		ProjectReq:         projectReq.(common.ProjectReq),
+		OpenstackSubnetReq: openstackReq.(OpenstackSubnetReq),
+	}, nil
+}