refactor: change IntOrString and ResourceQuantity from records to structs, update implicit conversions, and simplify null checks

Author: tg123

src/KubernetesClient/Models/IntOrString.cs

@@ -1,29 +1,29 @@
 namespace k8s.Models
 {
     [JsonConverter(typeof(IntOrStringJsonConverter))]
-    public record IntOrString
+    public struct IntOrString
     {
         [JsonPropertyName("value")]
-        public string Value { get; init; }
+        public string Value { get; private init; }
 
         public static implicit operator IntOrString(int v)
         {
-            return new IntOrString(Convert.ToString(v));
+            return Convert.ToString(v);
         }
 
         public static implicit operator IntOrString(long v)
         {
-            return new IntOrString(Convert.ToString(v));
+            return Convert.ToString(v);
         }
 
         public static implicit operator string(IntOrString v)
         {
-            return v?.Value;
+            return v.Value;
         }
 
         public static implicit operator IntOrString(string v)
         {
-            return new IntOrString(v);
+            return new IntOrString { Value = v };
         }
 
         public override string ToString()

src/KubernetesClient/Models/IntOrStringJsonConverter.cs

@@ -24,7 +24,7 @@ public override void Write(Utf8JsonWriter writer, IntOrString value, JsonSeriali
                 throw new ArgumentNullException(nameof(writer));
             }
 
-            var s = value?.Value;
+            var s = value.Value;
 
             if (long.TryParse(s, out var intv))
             {

src/KubernetesClient/Models/IntOrStringYamlConverter.cs

@@ -35,7 +35,7 @@ public object ReadYaml(IParser parser, Type type, ObjectDeserializer rootDeseria
         public void WriteYaml(IEmitter emitter, object value, Type type, ObjectSerializer serializer)
         {
             var obj = (IntOrString)value;
-            emitter?.Emit(new YamlDotNet.Core.Events.Scalar(obj?.Value));
+            emitter?.Emit(new YamlDotNet.Core.Events.Scalar(obj.Value));
         }
     }
 }

src/KubernetesClient/Models/ResourceQuantity.cs

@@ -54,7 +54,7 @@ namespace k8s.Models
     ///     cause implementors to also use a fixed point implementation.
     /// </summary>
     [JsonConverter(typeof(ResourceQuantityJsonConverter))]
-    public record ResourceQuantity
+    public struct ResourceQuantity
     {
         public enum SuffixFormat
         {
@@ -171,7 +171,7 @@ private static bool HasMantissa(Fraction value)
 
         public static implicit operator decimal(ResourceQuantity v)
         {
-            return v?.ToDecimal() ?? 0;
+            return v.ToDecimal();
         }
 
         public static implicit operator ResourceQuantity(decimal v)

src/KubernetesClient/Models/ResourceQuantityJsonConverter.cs

@@ -28,7 +28,7 @@ public override void Write(Utf8JsonWriter writer, ResourceQuantity value, JsonSe
                 throw new ArgumentNullException(nameof(writer));
             }
 
-            writer.WriteStringValue(value?.ToString());
+            writer.WriteStringValue(value.ToString());
         }
     }
 }

src/KubernetesClient/Models/ResourceQuantityYamlConverter.cs

@@ -35,7 +35,7 @@ public object ReadYaml(IParser parser, Type type, ObjectDeserializer rootDeseria
         public void WriteYaml(IEmitter emitter, object value, Type type, ObjectSerializer serializer)
         {
             var obj = (ResourceQuantity)value;
-            emitter?.Emit(new YamlDotNet.Core.Events.Scalar(obj?.ToString()));
+            emitter?.Emit(new YamlDotNet.Core.Events.Scalar(obj.ToString()));
         }
     }
 }

tests/KubernetesClient.Classic.Tests/SimpleTests.cs

@@ -7,7 +7,7 @@
 
 namespace k8s.tests;
 
-public class BasicTests
+public class SimpleTests
 {
     // TODO: fail to setup asp.net core 6 on net48
     private class DummyHttpServer : System.IDisposable