Skip to content

Commit 4cd062a

Browse files
authored
refactor: 🔨 use the more explicit singular form (#1129)
1 parent 916bc59 commit 4cd062a

File tree

1 file changed

+6
-5
lines changed

1 file changed

+6
-5
lines changed

‎pkg/epp/requestcontrol/director.go

Lines changed: 6 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -80,7 +80,7 @@ type Director struct {
8080
// 1. Parses request details.
8181
// 2. Calls admitRequest for admission control.
8282
// 3. Calls Scheduler.Schedule if request is approved.
83-
// 4. Calls prepareRequest to populate RequestContext with results and call PreRequest plugins.
83+
// 4. Calls prepareRequest to populate RequestContext with result and call PreRequest plugins.
8484
//
8585
// It always returns the requestContext even in the error case, as the request context is used in error handling.
8686
func (d *Director) HandleRequest(ctx context.Context, reqCtx *handlers.RequestContext) (*handlers.RequestContext, error) {
@@ -147,15 +147,15 @@ func (d *Director) HandleRequest(ctx context.Context, reqCtx *handlers.RequestCo
147147
if len(candidatePods) == 0 {
148148
return reqCtx, errutil.Error{Code: errutil.ServiceUnavailable, Msg: "failed to find candidate pods for serving the request"}
149149
}
150-
results, err := d.scheduler.Schedule(ctx, reqCtx.SchedulingRequest, candidatePods)
150+
result, err := d.scheduler.Schedule(ctx, reqCtx.SchedulingRequest, candidatePods)
151151
if err != nil {
152152
return reqCtx, errutil.Error{Code: errutil.InferencePoolResourceExhausted, Msg: fmt.Errorf("failed to find target pod: %w", err).Error()}
153153
}
154154

155155
// --- 4. Prepare Request (Populates RequestContext and call PreRequest plugins) ---
156156
// Insert target endpoint to instruct Envoy to route requests to the specified target pod and attach the port number.
157157
// Invoke PreRequest registered plugins.
158-
reqCtx, err = d.prepareRequest(ctx, reqCtx, results)
158+
reqCtx, err = d.prepareRequest(ctx, reqCtx, result)
159159
if err != nil {
160160
return reqCtx, err
161161
}
@@ -231,7 +231,7 @@ func (d *Director) getCandidatePodsForScheduling(ctx context.Context, requestMet
231231
}
232232

233233
// prepareRequest populates the RequestContext and calls the registered PreRequest plugins
234-
// for allowing plugging customized logic based on the scheduling results.
234+
// for allowing plugging customized logic based on the scheduling result.
235235
func (d *Director) prepareRequest(ctx context.Context, reqCtx *handlers.RequestContext, result *schedulingtypes.SchedulingResult) (*handlers.RequestContext, error) {
236236
logger := log.FromContext(ctx)
237237
if result == nil || len(result.ProfileResults) == 0 {
@@ -320,7 +320,8 @@ func RandomWeightedDraw(logger logr.Logger, model *v1alpha2.InferenceModel, seed
320320
}
321321

322322
func (d *Director) runPreRequestPlugins(ctx context.Context, request *schedulingtypes.LLMRequest, schedulingResult *schedulingtypes.SchedulingResult,
323-
targetPort int) {
323+
targetPort int,
324+
) {
324325
for _, plugin := range d.preRequestPlugins {
325326
log.FromContext(ctx).V(logutil.DEBUG).Info("Running pre-request plugin", "plugin", plugin.TypedName().Type)
326327
before := time.Now()

0 commit comments

Comments
 (0)