Skip to content

Commit a5cec7a

Browse files
committed
Log less verbose flags in less verbose mode
1 parent 2639ff4 commit a5cec7a

File tree

1 file changed

+9
-4
lines changed

1 file changed

+9
-4
lines changed

main.go

Lines changed: 9 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -525,7 +525,7 @@ func main() {
525525
"uid", os.Getuid(),
526526
"gid", os.Getgid(),
527527
"home", os.Getenv("HOME"),
528-
"flags", logSafeFlags())
528+
"flags", logSafeFlags(*flVerbose))
529529

530530
if _, err := exec.LookPath(*flGitCmd); err != nil {
531531
log.Error(err, "ERROR: git executable not found", "git", *flGitCmd)
@@ -928,14 +928,19 @@ func redactURL(urlstr string) string {
928928
// logSafeFlags makes sure any sensitive args (e.g. passwords) are redacted
929929
// before logging. This returns a slice rather than a map so it is always
930930
// sorted.
931-
func logSafeFlags() []string {
931+
func logSafeFlags(v int) []string {
932932
ret := []string{}
933933
pflag.VisitAll(func(fl *pflag.Flag) {
934+
// Don't log unchanged values
935+
if !fl.Changed && v <= 3 {
936+
return
937+
}
938+
934939
arg := fl.Name
935940
val := fl.Value.String()
936941

937-
// Don't log empty values
938-
if val == "" {
942+
// Don't log empty, unchanged values
943+
if val == "" && !fl.Changed && v < 6 {
939944
return
940945
}
941946

0 commit comments

Comments
 (0)