Skip to content

Commit c6bf01f

Browse files
authored
Merge branch 'master' into 21815
2 parents 2f420fc + 2912fc8 commit c6bf01f

File tree

7 files changed

+43
-28
lines changed

7 files changed

+43
-28
lines changed

Makefile

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@ KIC_VERSION ?= $(shell grep -E "Version =" pkg/drivers/kic/types.go | cut -d \"
2424
HUGO_VERSION ?= $(shell grep -E "HUGO_VERSION = \"" netlify.toml | cut -d \" -f2)
2525

2626
# Default to .0 for higher cache hit rates, as build increments typically don't require new ISO versions
27-
ISO_VERSION ?= v1.37.0-1761414747-21797
27+
ISO_VERSION ?= v1.37.0-1761658712-21800
2828

2929
# Dashes are valid in semver, but not Linux packaging. Use ~ to delimit alpha/beta
3030
DEB_VERSION ?= $(subst -,~,$(RAW_VERSION))

deploy/iso/minikube-iso/board/minikube/aarch64/linux_aarch64_defconfig

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -947,7 +947,7 @@ CONFIG_CMA_SIZE_MBYTES=32
947947
CONFIG_PRINTK_TIME=y
948948
CONFIG_DEBUG_KERNEL=y
949949
CONFIG_DEBUG_INFO_DWARF_TOOLCHAIN_DEFAULT=y
950-
CONFIG_DEBUG_INFO_REDUCED=y
950+
CONFIG_DEBUG_INFO_BTF=y
951951
CONFIG_MAGIC_SYSRQ=y
952952
CONFIG_DEBUG_FS=y
953953
# CONFIG_SCHED_DEBUG is not set

deploy/iso/minikube-iso/board/minikube/x86_64/linux_x86_64_defconfig

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -502,13 +502,17 @@ CONFIG_CRYPTO_USER_API_SKCIPHER=y
502502
CONFIG_CRYPTO_AES_NI_INTEL=y
503503
CONFIG_PRINTK_TIME=y
504504
CONFIG_DEBUG_KERNEL=y
505+
CONFIG_DEBUG_INFO_DWARF_TOOLCHAIN_DEFAULT=y
506+
CONFIG_DEBUG_INFO_BTF=y
505507
CONFIG_MAGIC_SYSRQ=y
506508
CONFIG_DEBUG_STACK_USAGE=y
507509
# CONFIG_SCHED_DEBUG is not set
508510
CONFIG_SCHEDSTATS=y
509511
CONFIG_FUNCTION_TRACER=y
510512
CONFIG_FTRACE_SYSCALLS=y
511513
CONFIG_BLK_DEV_IO_TRACE=y
514+
CONFIG_BPF_KPROBE_OVERRIDE=y
512515
CONFIG_PROVIDE_OHCI1394_DMA_INIT=y
513516
CONFIG_EARLY_PRINTK_DBGP=y
514517
CONFIG_DEBUG_BOOT_PARAMS=y
518+
CONFIG_FUNCTION_ERROR_INJECTION=y

pkg/minikube/download/iso.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -41,7 +41,7 @@ const fileScheme = "file"
4141
// DefaultISOURLs returns a list of ISO URL's to consult by default, in priority order
4242
func DefaultISOURLs() []string {
4343
v := version.GetISOVersion()
44-
isoBucket := "minikube-builds/iso/21797"
44+
isoBucket := "minikube-builds/iso/21800"
4545

4646
return []string{
4747
fmt.Sprintf("https://storage.googleapis.com/%s/minikube-%s-%s.iso", isoBucket, v, runtime.GOARCH),

pkg/minikube/service/service_test.go

Lines changed: 21 additions & 24 deletions
Original file line numberDiff line numberDiff line change
@@ -21,6 +21,7 @@ import (
2121
"context"
2222
"fmt"
2323
"os"
24+
"path/filepath"
2425
"reflect"
2526
"strings"
2627
"testing"
@@ -712,45 +713,41 @@ preferences: {}
712713
users:
713714
- name: minikube
714715
`
715-
var tests = []struct {
716-
description string
717-
kubeconfigPath string
718-
config string
719-
err bool
716+
tests := []struct {
717+
description string
718+
config string
719+
err bool
720720
}{
721721
{
722-
description: "ok",
723-
kubeconfigPath: "/tmp/kube_config",
724-
config: mockK8sConfig,
725-
err: false,
722+
description: "ok",
723+
config: mockK8sConfig,
724+
err: false,
726725
},
727726
{
728-
description: "empty config",
729-
kubeconfigPath: "/tmp/kube_config",
730-
config: "",
731-
err: true,
727+
description: "empty config",
728+
config: "",
729+
err: true,
732730
},
733731
{
734-
description: "broken config",
735-
kubeconfigPath: "/tmp/kube_config",
736-
config: "this**is&&not: yaml::valid: file",
737-
err: true,
732+
description: "broken config",
733+
config: "this**is&&not: yaml::valid: file",
734+
err: true,
738735
},
739736
}
740737

741738
for _, test := range tests {
742739
t.Run(test.description, func(t *testing.T) {
743-
mockK8sConfigByte := []byte(test.config)
744-
mockK8sConfigPath := test.kubeconfigPath
745-
err := os.WriteFile(mockK8sConfigPath, mockK8sConfigByte, 0644)
746-
defer os.Remove(mockK8sConfigPath)
747-
if err != nil {
748-
t.Fatalf("Unexpected error when writing to file %v. Error: %v", test.kubeconfigPath, err)
740+
tmpDir := t.TempDir()
741+
mockK8sConfigPath := filepath.Join(tmpDir, "kube_config")
742+
743+
if err := os.WriteFile(mockK8sConfigPath, []byte(test.config), 0600); err != nil {
744+
t.Fatalf("failed to write kubeconfig: %v", err)
749745
}
750746
t.Setenv("KUBECONFIG", mockK8sConfigPath)
751747

752748
k8s := K8sClientGetter{}
753-
_, err = k8s.GetCoreClient("minikube")
749+
_, err := k8s.GetCoreClient("minikube")
750+
754751
if err != nil && !test.err {
755752
t.Fatalf("GetCoreClient returned unexpected error: %v", err)
756753
}

site/config.toml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -165,7 +165,7 @@ no = 'Sorry to hear that. Please <a href="https://github.com/kubernetes/minikube
165165
[[params.links.developer]]
166166
name = "Project Roadmap"
167167
url = "https://minikube.sigs.k8s.io/docs/contrib/roadmap/"
168-
icon = "fas fa-external-link-alt"
168+
icon = "fas fa-map"
169169
desc = "Check out the project roadmap"
170170

171171
# minikube meetings

test/integration/iso_test.go

Lines changed: 14 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -24,6 +24,7 @@ import (
2424
"fmt"
2525
"os/exec"
2626
"runtime"
27+
"strings"
2728
"testing"
2829

2930
"k8s.io/minikube/pkg/minikube/vmpath"
@@ -117,4 +118,17 @@ func TestISOImage(t *testing.T) {
117118
t.Logf(" %s: %s", k, v)
118119
}
119120
})
121+
122+
t.Run("eBPFSupport", func(t *testing.T) {
123+
// Ensure that BTF type information is available (https://github.com/kubernetes/minikube/issues/21788)
124+
btfFile := "/sys/kernel/btf/vmlinux"
125+
rr, err := Run(t, exec.CommandContext(ctx, Target(), "-p", profile, "ssh", fmt.Sprintf("test -f %s && echo 'OK' || echo 'NOT FOUND'", btfFile)))
126+
if err != nil {
127+
t.Errorf("failed to verify existence of %q file: args %q: %v", btfFile, rr.Command(), err)
128+
}
129+
130+
if !strings.Contains(rr.Stdout.String(), "OK") {
131+
t.Errorf("expected file %q to exist, but it does not. BTF types are required for CO-RE eBPF programs; set CONFIG_DEBUG_INFO_BTF in kernel configuration.", btfFile)
132+
}
133+
})
120134
}

0 commit comments

Comments
 (0)