Skip to content

Conversation

@r-ohan019
Copy link

…sion

  • Replace local pkg/util/cert/watcher with sigs.k8s.io/controller-runtime/pkg/certwatcher
  • Update BUILD.bazel dependencies in cdi-apiserver and cdi-uploadproxy
  • Update Go imports to use vendored certwatcher package
  • Update API usage to use context.Context instead of stopCh
  • Remove duplicate 2019 certwatcher implementation
  • Use actively maintained 2021 version with enhanced features

Fixes #3620

…sion

- Replace local pkg/util/cert/watcher with sigs.k8s.io/controller-runtime/pkg/certwatcher
- Update BUILD.bazel dependencies in cdi-apiserver and cdi-uploadproxy
- Update Go imports to use vendored certwatcher package
- Update API usage to use context.Context instead of stopCh
- Remove duplicate 2019 certwatcher implementation
- Use actively maintained 2021 version with enhanced features

Fixes kubevirt#3620
@kubevirt-bot
Copy link
Contributor

Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@kubevirt-bot kubevirt-bot added do-not-merge/invalid-commit-message Indicates that a PR should not merge because it has an invalid commit message. dco-signoff: no Indicates the PR's author has not DCO signed all their commits. labels Aug 26, 2025
@kubevirt-bot
Copy link
Contributor

Keywords which can automatically close issues and at(@) or hashtag(#) mentions are not allowed in commit messages.

The list of commits with invalid commit messages:

  • efc0c3f Migrate from duplicate certwatcher to vendored controller-runtime version

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@kubevirt-bot kubevirt-bot added the do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. label Aug 26, 2025
@kubevirt-bot
Copy link
Contributor

Thanks for your pull request. Before we can look at it, you'll need to add a 'DCO signoff' to your commits.

📝 Please follow instructions in the contributing guide to update your commits with the DCO

Full details of the Developer Certificate of Origin can be found at developercertificate.org.

The list of commits missing DCO signoff:

  • efc0c3f Migrate from duplicate certwatcher to vendored controller-runtime version

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@kubevirt-bot
Copy link
Contributor

Hi @r-ohan019. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@kubevirt-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign akalenyu for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@akalenyu
Copy link
Collaborator

Thanks for the PR!
Can you sign the commit and remove the special characters from the commit message, so the bot stops complaining

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dco-signoff: no Indicates the PR's author has not DCO signed all their commits. do-not-merge/invalid-commit-message Indicates that a PR should not merge because it has an invalid commit message. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. size/L

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Two Cert Manager functions for cdi-apiserver

4 participants